Skip to content

Conversation

@jackpope
Copy link
Contributor

@jackpope jackpope commented Dec 5, 2024

No description provided.

@vercel
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 6:16pm

@react-sizebot
Copy link

Comparing: 1c9b138714a69cd136a3d82769b1fd9a4b318953...140014c46a9994611ff7347709173c45b8b2c35a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.81 kB 510.81 kB = 91.43 kB 91.43 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.74 kB 515.74 kB = 92.14 kB 92.14 kB
facebook-www/ReactDOM-prod.classic.js = 595.67 kB 595.67 kB = 105.14 kB 105.14 kB
facebook-www/ReactDOM-prod.modern.js = 585.93 kB 585.93 kB = 103.57 kB 103.57 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 3e4a101

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickhanlonii rickhanlonii merged commit 52685a7 into facebook:main Dec 5, 2024
184 checks passed
### New Features

### React
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### React
#### React

Here and below: I guess we need to use level 4 instead of level 3 for sub-headers of New features, Breaking Changes so on. That will ensure the right semantic structure of the document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants