Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flight] Handle bound arguments for loaded server references #31302

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

sebmarkbage
Copy link
Collaborator

Follow up to #31300.

I forgot to pass the bound arguments to the loaded function.

Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 6:11am

@react-sizebot
Copy link

react-sizebot commented Oct 20, 2024

Comparing: c1e1358...c97a707

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 506.86 kB 506.86 kB = 90.71 kB 90.71 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 511.79 kB 511.79 kB = 91.42 kB 91.43 kB
facebook-www/ReactDOM-prod.classic.js = 604.26 kB 604.26 kB = 106.92 kB 106.92 kB
facebook-www/ReactDOM-prod.modern.js = 580.48 kB 580.48 kB = 103.00 kB 103.01 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.53% 49.86 kB 50.13 kB +0.76% 10.16 kB 10.23 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.53% 49.86 kB 50.13 kB +0.76% 10.16 kB 10.23 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.53% 49.86 kB 50.13 kB +0.76% 10.16 kB 10.23 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js +0.53% 50.37 kB 50.63 kB +0.78% 10.24 kB 10.32 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.51% 51.73 kB 51.99 kB +0.69% 10.55 kB 10.62 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.51% 51.73 kB 51.99 kB +0.69% 10.55 kB 10.62 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.51% 51.73 kB 51.99 kB +0.69% 10.55 kB 10.62 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.51% 52.06 kB 52.33 kB +0.68% 10.64 kB 10.71 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.51% 52.06 kB 52.33 kB +0.68% 10.64 kB 10.71 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.51% 52.06 kB 52.33 kB +0.68% 10.64 kB 10.71 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js +0.51% 52.23 kB 52.50 kB +0.70% 10.63 kB 10.71 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js +0.50% 52.57 kB 52.83 kB +0.68% 10.73 kB 10.80 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.49% 53.78 kB 54.04 kB +0.66% 11.02 kB 11.09 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.49% 53.78 kB 54.04 kB +0.66% 11.02 kB 11.09 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.49% 53.78 kB 54.04 kB +0.66% 11.02 kB 11.09 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js +0.49% 54.29 kB 54.55 kB +0.60% 11.10 kB 11.17 kB
oss-stable-rc/react-client/cjs/react-client-flight.production.js +0.48% 56.58 kB 56.86 kB +0.66% 10.53 kB 10.60 kB
oss-stable-semver/react-client/cjs/react-client-flight.production.js +0.48% 56.58 kB 56.86 kB +0.66% 10.53 kB 10.60 kB
oss-stable/react-client/cjs/react-client-flight.production.js +0.48% 56.60 kB 56.88 kB +0.65% 10.55 kB 10.62 kB
oss-experimental/react-client/cjs/react-client-flight.production.js +0.48% 57.02 kB 57.29 kB +0.66% 10.61 kB 10.68 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.47% 56.06 kB 56.33 kB +0.62% 11.48 kB 11.55 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.47% 56.06 kB 56.33 kB +0.62% 11.48 kB 11.55 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.47% 56.06 kB 56.33 kB +0.62% 11.48 kB 11.55 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js +0.47% 56.57 kB 56.84 kB +0.57% 11.56 kB 11.62 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.46% 57.55 kB 57.81 kB +0.58% 11.80 kB 11.87 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.46% 57.55 kB 57.81 kB +0.58% 11.80 kB 11.87 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.46% 57.55 kB 57.81 kB +0.58% 11.80 kB 11.87 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.46% 57.56 kB 57.82 kB +0.59% 11.78 kB 11.85 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.46% 57.56 kB 57.82 kB +0.59% 11.78 kB 11.85 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.46% 57.56 kB 57.82 kB +0.59% 11.78 kB 11.85 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js +0.46% 58.05 kB 58.32 kB +0.58% 11.88 kB 11.95 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js +0.46% 58.07 kB 58.33 kB +0.61% 11.86 kB 11.93 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.45% 58.58 kB 58.84 kB +0.62% 11.76 kB 11.84 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.45% 58.58 kB 58.84 kB +0.62% 11.76 kB 11.84 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.45% 58.58 kB 58.84 kB +0.62% 11.76 kB 11.84 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js +0.45% 59.07 kB 59.33 kB +0.61% 11.85 kB 11.92 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.44% 59.65 kB 59.92 kB +0.57% 12.00 kB 12.06 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.44% 59.65 kB 59.92 kB +0.57% 12.00 kB 12.06 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.44% 59.65 kB 59.92 kB +0.57% 12.00 kB 12.06 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js +0.44% 60.14 kB 60.41 kB +0.55% 12.08 kB 12.14 kB
oss-stable-rc/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.43% 81.80 kB 82.14 kB +0.68% 17.12 kB 17.24 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.43% 81.80 kB 82.14 kB +0.68% 17.12 kB 17.24 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.43% 81.80 kB 82.14 kB +0.68% 17.12 kB 17.24 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js +0.42% 82.53 kB 82.88 kB +0.67% 17.23 kB 17.35 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.32% 87.43 kB 87.72 kB +0.53% 16.62 kB 16.71 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.32% 87.43 kB 87.72 kB +0.53% 16.62 kB 16.71 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.32% 87.48 kB 87.76 kB +0.52% 16.64 kB 16.73 kB
oss-stable-rc/react-client/cjs/react-client-flight.development.js +0.32% 88.79 kB 89.07 kB +0.42% 16.25 kB 16.32 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js +0.32% 88.79 kB 89.07 kB +0.42% 16.25 kB 16.32 kB
oss-stable/react-client/cjs/react-client-flight.development.js +0.32% 88.81 kB 89.09 kB +0.42% 16.27 kB 16.34 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.32% 89.57 kB 89.86 kB +0.52% 17.01 kB 17.09 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.32% 89.57 kB 89.86 kB +0.52% 17.01 kB 17.09 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.32% 89.62 kB 89.90 kB +0.51% 17.03 kB 17.11 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.31% 90.03 kB 90.31 kB +0.51% 17.12 kB 17.21 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.31% 90.03 kB 90.31 kB +0.51% 17.12 kB 17.21 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.31% 90.07 kB 90.35 kB +0.51% 17.14 kB 17.23 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.31% 91.14 kB 91.43 kB +0.40% 17.24 kB 17.30 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.31% 91.14 kB 91.43 kB +0.40% 17.24 kB 17.30 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.31% 91.14 kB 91.43 kB +0.40% 17.24 kB 17.30 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.30% 93.73 kB 94.02 kB +0.40% 17.70 kB 17.77 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.30% 93.73 kB 94.02 kB +0.40% 17.70 kB 17.77 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.30% 93.73 kB 94.02 kB +0.40% 17.70 kB 17.77 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.30% 95.35 kB 95.63 kB +0.40% 18.09 kB 18.16 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.30% 95.47 kB 95.75 kB +0.38% 18.06 kB 18.13 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.30% 95.47 kB 95.75 kB +0.38% 18.06 kB 18.13 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.30% 95.47 kB 95.75 kB +0.38% 18.06 kB 18.13 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.30% 95.48 kB 95.76 kB +0.39% 18.04 kB 18.11 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.30% 95.48 kB 95.76 kB +0.39% 18.04 kB 18.11 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.30% 95.48 kB 95.76 kB +0.39% 18.04 kB 18.11 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.29% 96.48 kB 96.76 kB +0.38% 17.96 kB 18.03 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.29% 96.48 kB 96.76 kB +0.38% 17.96 kB 18.03 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.29% 96.48 kB 96.76 kB +0.38% 17.96 kB 18.03 kB
oss-experimental/react-client/cjs/react-client-flight.development.js +0.29% 96.67 kB 96.96 kB +0.40% 17.80 kB 17.87 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.29% 97.49 kB 97.77 kB +0.40% 18.48 kB 18.55 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.29% 97.70 kB 97.99 kB +0.37% 18.21 kB 18.27 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.29% 97.70 kB 97.99 kB +0.37% 18.21 kB 18.27 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.29% 97.70 kB 97.99 kB +0.37% 18.21 kB 18.27 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.29% 97.94 kB 98.22 kB +0.39% 18.60 kB 18.67 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.29% 99.15 kB 99.44 kB +0.38% 18.73 kB 18.80 kB
oss-stable-rc/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.28% 122.82 kB 123.17 kB +0.38% 28.36 kB 28.47 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.28% 122.82 kB 123.17 kB +0.38% 28.36 kB 28.47 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.28% 122.84 kB 123.19 kB +0.39% 28.38 kB 28.49 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.28% 101.75 kB 102.03 kB +0.36% 19.20 kB 19.27 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.27% 103.48 kB 103.76 kB +0.35% 19.53 kB 19.60 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.27% 103.49 kB 103.78 kB +0.35% 19.51 kB 19.58 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.27% 104.49 kB 104.77 kB +0.34% 19.46 kB 19.53 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.27% 105.72 kB 106.00 kB +0.35% 19.70 kB 19.77 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.26% 134.07 kB 134.42 kB +0.38% 31.12 kB 31.24 kB

Generated by 🚫 dangerJS against d3e6012

@sebmarkbage sebmarkbage merged commit 251b666 into facebook:main Oct 20, 2024
159 of 161 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants