Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Allow passing various params to compiler publish script #31283

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[ci] Allow passing various params to compiler publish script #31283

merged 1 commit into from
Oct 17, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Oct 17, 2024 •
edited
Loading

Allow passing in a few more inputs when manually publishing.

@vercel Vercel
Copy link

vercel bot commented Oct 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 10:04pm

@poteto poteto mentioned this pull request Oct 17, 2024
Merged
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 17, 2024
@poteto poteto marked this pull request as ready for review October 17, 2024 21:51
@poteto poteto force-pushed the pr31283 branch 2 times, most recently from 5474d35 to 15af99b Compare October 17, 2024 21:55
@react-sizebot
Copy link

react-sizebot commented Oct 17, 2024 •
edited
Loading

Comparing: 9c60cbe...94bec9f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 506.53 kB 506.53 kB = 90.68 kB 90.68 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 511.47 kB 511.47 kB = 91.40 kB 91.40 kB
facebook-www/ReactDOM-prod.classic.js = 603.93 kB 603.93 kB = 106.88 kB 106.88 kB
facebook-www/ReactDOM-prod.modern.js = 580.15 kB 580.15 kB = 102.97 kB 102.97 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 053a210

poteto added a commit that referenced this pull request Oct 17, 2024
@poteto
[compiler] Clean up publish script (#31278)
9c60cbe 
Few small tweaks to make it easier to run adhoc publishes
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31278).
* #31283
* __->__ #31278
@poteto
[ci] Allow passing various params to compiler publish script
053a210 
Allow passing in a few more inputs when manually publishing.
@poteto poteto merged commit 25cac22 into main Oct 17, 2024
187 checks passed
@poteto poteto deleted the pr31283 branch October 17, 2024 22:13
@vercel-release-bot vercel-release-bot mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poteto @react-sizebot @facebook-github-bot