Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify perform{Sync,Concurrent}WorkOnRoot implementation #31029

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Unify perform{Sync,Concurrent}WorkOnRoot implementation #31029

merged 2 commits into from
Sep 25, 2024
+115 −176

Commits on Sep 23, 2024

  1. Tweak test a bit to clarify intended behavior

    @acdlite
    acdlite committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9316eb2 View commit details
    Browse the repository at this point in the history

  2. Unify perform{Sync,Concurrent}WorkOnRoot impl 

    Over time the behavior of these two paths has converged to be
essentially the same. So this merges them back into one function. This
should save some code size and also make it harder for the behavior to
accidentally diverge. (For the same reason, rolling out this change
might expose some areas where we had already accidentally diverged.)
    @acdlite
    acdlite committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5833022 View commit details
    Browse the repository at this point in the history