Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] Track Tree Base Duration of Virtual Instances #30817

Merged
merged 3 commits into from
Aug 27, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mention that these didn't client render to clarify
We don't track the difference between a virtual instance and a Fiber that
didn't render this update. This might be a bit confusing as to why it didn't
render. I add the word "client" to make it a bit clearer.

But really we should probably have different verbiage here based on it is
a Server Component or something else.
  • Loading branch information
sebmarkbage committed Aug 26, 2024
commit b65c514e51fd2ff311e8c65b9bfcd3e9150d5554
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export default function HoveredFiberInfo({fiberData}: Props): React.Node {
)}

<div className={styles.Content}>
{renderDurationInfo || <div>Did not render.</div>}
{renderDurationInfo || <div>Did not client render.</div>}

<WhatChanged fiberID={id} />
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export default function SidebarSelectedFiberInfo(): React.Node {
</div>
)}
{listItems.length === 0 && (
<div>Did not render during this profiling session.</div>
<div>Did not render on the client during this profiling session.</div>
)}
</div>
</Fragment>
Expand Down