-
Notifications
You must be signed in to change notification settings - Fork 46.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler][be] Less ambiguous error messages for validateMemo bailout #30601
Conversation
[ghstack-poisoned]
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…emo bailout" [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. The dependency one is very clear, for the “value not memoized” case it might be nice to explain why “(because it may be mutated later)” but I like how you’re clarifying the two cases.
…emo bailout" [ghstack-poisoned]
suggestions: null, | ||
}); | ||
} | ||
} | ||
} | ||
if (value.kind === 'FinishMemoize') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: else if
ghstack-source-id: 312093ec74d733bccd2d2d8400eaba267c9e33a7 Pull Request resolved: #30601
Stack from ghstack (oldest at bottom):