Skip to content

[compiler] Simplify FunctionExpression node #30544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2024
Merged

[compiler] Simplify FunctionExpression node #30544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/packages/babel-plugin-react-compiler/src/HIR/BuildHIR.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3270,7 +3270,7 @@ function lowerFunctionToValue(
return {
kind: 'FunctionExpression',
name,
expr: expr.node,
type: expr.node.type,
loc: exprLoc,
loweredFunc,
};
Expand Down
8 changes: 4 additions & 4 deletions compiler/packages/babel-plugin-react-compiler/src/HIR/HIR.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,10 +1076,10 @@ export type FunctionExpression = {
kind: 'FunctionExpression';
name: string | null;
loweredFunc: LoweredFunction;
expr:
| t.ArrowFunctionExpression
| t.FunctionExpression
| t.FunctionDeclaration;
type:
| 'ArrowFunctionExpression'
| 'FunctionExpression'
| 'FunctionDeclaration';
loc: SourceLocation;
};

Expand Down
2 changes: 1 addition & 1 deletion compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/CodegenReactiveFunction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1997,7 +1997,7 @@ function codegenInstructionValue(
),
reactiveFunction,
).unwrap();
if (instrValue.expr.type === 'ArrowFunctionExpression') {
if (instrValue.type === 'ArrowFunctionExpression') {
let body: t.BlockStatement | t.Expression = fn.body;
if (body.body.length === 1 && loweredFunc.directives.length == 0) {
const stmt = body.body[0]!;
Expand Down