Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler][patch] Patch O(n^2) traversal in validatePreserveMemo #30077

Merged
merged 3 commits into from
Jun 25, 2024
Merged

[compiler][patch] Patch O(n^2) traversal in validatePreserveMemo #30077

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79198b0
[compiler][patch] Patch O(n^2) traversal in validatePreserveMemo
mofeiZ Jun 24, 2024
761bef9
Update on "[compiler][patch] Patch O(n^2) traversal in validatePreser…
mofeiZ Jun 25, 2024
eca7846
Update on "[compiler][patch] Patch O(n^2) traversal in validatePreser…
mofeiZ Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update on "[compiler][patch] Patch O(n^2) traversal in validatePreser… 
…veMemo"

Double checked by syncing internally and verifying the # of `visitInstruction` calls with unique `InstructionId`s.

This is a bit of an awkward pattern though. A cleaner alternative might be to override `visitValue` and store its results in a sidemap (instead of returning)

[ghstack-poisoned]
  • Loading branch information
@mofeiZ
mofeiZ committed Jun 25, 2024
commit eca784639c63ca3b2d67707d2e0941b3b56aa666

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.