-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[compiler] remove duplicate parsePluginOptions from the compilePro… #29831
fix[compiler] remove duplicate parsePluginOptions from the compilePro… #29831
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comparing: 6b35ff7...bc3765c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice catch, thanks!
also please run |
8cdc67d
to
bc3765c
Compare
Thank you for your review! |
Thanks for the PR! |
Summary
The parsePluginOptions seemed to be duplicated within BabelPlugin.ts and Program.ts.
Since the options already parsed in BabelPlugin.ts should have been passed to compileProgram, in this PR we deleted parsePluginOptions in compileProgram and used the options passed as arguments as they are. I've done that.
How did you test this change?