Skip to content

[compiler] Check for __DEV__ for FastRefresh #29785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Jun 6, 2024

Stack from ghstack (oldest at bottom):

We don't always have the NODE_ENV set, so additionally check for the
DEV global if it has one set.

[ghstack-poisoned]
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 5:45pm

poteto added a commit that referenced this pull request Jun 6, 2024
ghstack-source-id: 66978ee
Pull Request resolved: #29785
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 6, 2024
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 6, 2024
ghstack-source-id: 776e8c5
Pull Request resolved: #29785
poteto added a commit that referenced this pull request Jun 6, 2024
We don't always have the NODE_ENV set, so additionally check for the
__DEV__ global if it has one set.

ghstack-source-id: 776e8c5
Pull Request resolved: #29785
@react-sizebot
Copy link

react-sizebot commented Jun 6, 2024

Comparing: 1e1e5cd...68caacf

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.26 kB 497.26 kB = 89.11 kB 89.11 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.08 kB 502.08 kB = 89.80 kB 89.80 kB
facebook-www/ReactDOM-prod.classic.js = 594.56 kB 594.56 kB = 104.72 kB 104.72 kB
facebook-www/ReactDOM-prod.modern.js = 570.95 kB 570.95 kB = 101.13 kB 101.13 kB
test_utils/ReactAllWarnings.js Deleted 63.89 kB 0.00 kB Deleted 15.97 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 63.89 kB 0.00 kB Deleted 15.97 kB 0.00 kB

Generated by 🚫 dangerJS against 68caacf

Copy link
Member

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

[ghstack-poisoned]
poteto added a commit that referenced this pull request Jun 6, 2024
We don't always have the NODE_ENV set, so additionally check for the
__DEV__ global if it has one set.

ghstack-source-id: 3719a47
Pull Request resolved: #29785
@poteto poteto merged commit 68caacf into gh/poteto/16/base Jun 6, 2024
55 checks passed
poteto added a commit that referenced this pull request Jun 6, 2024
We don't always have the NODE_ENV set, so additionally check for the
__DEV__ global if it has one set.

ghstack-source-id: 3719a47
Pull Request resolved: #29785
@poteto poteto deleted the gh/poteto/16/head branch June 6, 2024 17:55
github-actions bot pushed a commit that referenced this pull request Jun 6, 2024
We don't always have the NODE_ENV set, so additionally check for the
__DEV__ global if it has one set.

ghstack-source-id: 3719a47
Pull Request resolved: #29785

DiffTrain build for commit 29b1278.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants