Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up experimental flags #28116

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Clean up experimental flags #28116

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76f14eb
Clean up experimental flags and turn some on
rickhanlonii Jan 26, 2024
2669eef
dont' turn the flags on yet
rickhanlonii Jan 26, 2024
12aa92c
Just inline it
rickhanlonii Jan 29, 2024
ad10c63
Revert webpack.backend.js change
rickhanlonii Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dont' turn the flags on yet
  • Loading branch information
@rickhanlonii
rickhanlonii committed Jan 26, 2024
commit 2669eefebf41e542d579d9b0737917edb6f864b4
16 changes: 9 additions & 7 deletions packages/shared/ReactFeatureFlags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,19 @@ export const transitionLaneExpirationMs = 5000;
// -----------------------------------------------------------------------------

// Not ready to break experimental yet.
export const disableLegacyContext = __NEXT_MAJOR__;
export const disableLegacyContext = false;

// Not ready to break experimental yet.
// Disable javascript: URL strings in href for XSS protection.
export const disableJavaScriptURLs = __NEXT_MAJOR__;
export const disableJavaScriptURLs = false;

// Not ready to break experimental yet.
// Modern <StrictMode /> behaviour aligns more with what components
// components will encounter in production, especially when used With <Offscreen />.
// TODO: clean up legacy <StrictMode /> once tests pass WWW.
export const useModernStrictMode = false;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll turn these on in experimental in follow up PRs.


// Not ready to break experimental yet.
// Remove IE and MsApp specific workarounds for innerHTML
export const disableIEWorkarounds = __NEXT_MAJOR__;

Expand All @@ -161,11 +168,6 @@ export const enableCustomElementPropertySupport = __NEXT_MAJOR__;
// request for certain browsers.
export const enableFilterEmptyStringAttributesDOM = __NEXT_MAJOR__;

// Modern <StrictMode /> behaviour aligns more with what components
// components will encounter in production, especially when used With <Offscreen />.
// TODO: clean up legacy <StrictMode /> once tests pass WWW.
export const useModernStrictMode = __NEXT_MAJOR__;

// -----------------------------------------------------------------------------
// Chopping Block
//
Expand Down