Add a feature flag to enable expiration of retry lanes #27694
Merged
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
An attempt to see if we can bring back expiration of retry lanes to avoid cases resolving Suspense can be starved by frequent updates.
kassens
force-pushed
the
enableRetryLaneExpiration
branch
from
57f829a to
560f7bf
Compare
tyao1
reviewed
Nov 13, 2023
Contributor
tyao1
left a comment
tyao1
left a comment
There was a problem hiding this comment.
Could we add the minimal repro as a regression test here or in a follow up? That will verify it fixes the issue and other feature flags don't affect it.
tyao1
approved these changes
Nov 13, 2023
acdlite
approved these changes
Nov 14, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
An attempt to see if we can bring back expiration of retry lanes to avoid cases resolving Suspense can be starved by frequent updates. In the past, this caused increase browser crashes, but a lot of time has passed since then. Just trying if we can re-enable this. Old PR that reverted adding the timeout: #21300 DiffTrain build for [593ecee](593ecee)
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 15, 2023
### React upstream changes - facebook/react#27694 - facebook/react#27695 - facebook/react#27689 - facebook/react#27687 - facebook/react#27677 - facebook/react#27681
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
An attempt to see if we can bring back expiration of retry lanes to avoid cases resolving Suspense can be starved by frequent updates. In the past, this caused increase browser crashes, but a lot of time has passed since then. Just trying if we can re-enable this. Old PR that reverted adding the timeout: facebook#21300
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
An attempt to see if we can bring back expiration of retry lanes to avoid cases resolving Suspense can be starved by frequent updates. In the past, this caused increase browser crashes, but a lot of time has passed since then. Just trying if we can re-enable this. Old PR that reverted adding the timeout: #21300 DiffTrain build for commit 593ecee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to see if we can bring back expiration of retry lanes to avoid cases resolving Suspense can be starved by frequent updates.
In the past, this caused increase browser crashes, but a lot of time has passed since then. Just trying if we can re-enable this.
Old PR that reverted adding the timeout: #21300