Skip to content

feat:-Added a delete all filters action and added title to the add filter a… #27332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoxyq merged 2 commits into from
Sep 20, 2023
Merged

feat:-Added a delete all filters action and added title to the add filter a… #27332

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc69c9e
Added a delete all filters action and added title to the add filter a…
Sep 4, 2023
8c7a200
Update packages/react-devtools-shared/src/devtools/views/Settings/Com…
Biki-das Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/react-devtools-shared/src/devtools/views/Settings/ComponentsSettings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,10 @@ export default function ComponentsSettings(_: {}): React.Node {
});
}, []);

const removeAllFilter = () => {
setComponentFilters([]);
};

const toggleFilterIsEnabled = useCallback(
(componentFilter: ComponentFilter, isEnabled: boolean) => {
setComponentFilters(prevComponentFilters => {
Expand Down Expand Up @@ -434,11 +438,16 @@ export default function ComponentsSettings(_: {}): React.Node {
))}
</tbody>
</table>

<Button onClick={addFilter}>
<Button onClick={addFilter} title="Add filter">
<ButtonIcon className={styles.ButtonIcon} type="add" />
Add filter
</Button>
{componentFilters.length > 0 && (
<Button onClick={removeAllFilter} title="Delete all filters">
<ButtonIcon className={styles.ButtonIcon} type="delete" />
Delete all filters
</Button>
)}
</div>
);
}
Expand Down