[Flight] Serialize weird numbers #26623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
reviewed
Apr 14, 2023
sebmarkbage
reviewed
Apr 14, 2023
sophiebits
force-pushed
the
flight-wnums
branch
from
6c4db12 to
270582a
Compare
eps1lon
approved these changes
Apr 14, 2023
sophiebits
force-pushed
the
flight-wnums
branch
from
270582a to
2264ffc
Compare
sebmarkbage
reviewed
Apr 14, 2023
| } | ||
| case '-': { | ||
| // $-0 or $-Infinity | ||
| if (value[2] === '0') { |
Collaborator
There was a problem hiding this comment.
Because of interning and that you don’t have to do a type check, so there’s nothing to recompile during a deopt, it might be better to just compare to the full string.
The reason not to do it for the outer check is that the common case needs to extract a partial anyway so we’re just using the same case.
Collaborator
Author
There was a problem hiding this comment.
for the outer switch – I was thinking about it last night and I wonder if switching on charCodeAt is likely faster?
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Apr 14, 2023
Maybe this is faster. facebook#26623 (comment)
sophiebits
added a commit
that referenced
this pull request
Apr 14, 2023
Maybe this is faster. #26623 (comment)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 14, 2023
Maybe this is faster. #26623 (comment) DiffTrain build for [2bfe4b2](2bfe4b2)
Closed
kassens
added a commit
to kassens/react
that referenced
this pull request
Apr 17, 2023
This reverts commit 2bfe4b2.
kassens
added a commit
to kassens/react
that referenced
this pull request
Apr 17, 2023
This reverts commit ab2385f.
kassens
pushed a commit
that referenced
this pull request
Apr 21, 2023
kassens
pushed a commit
that referenced
this pull request
Apr 21, 2023
Maybe this is faster. #26623 (comment)
jerrydev0927
added a commit
to jerrydev0927/react
that referenced
this pull request
Jan 5, 2024
Maybe this is faster. facebook/react#26623 (comment) DiffTrain build for [2bfe4b246f58d1f8d357f984fba9a8aa1fa79c73](facebook/react@2bfe4b2)
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Maybe this is faster. facebook#26623 (comment)
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
DiffTrain build for commit ab2385f.
Akshato07
pushed a commit
to Akshato07/-Luffy
that referenced
this pull request
Feb 20, 2025
Maybe this is faster. facebook/react#26623 (comment) DiffTrain build for commit facebook/react@2bfe4b2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.