[Flight] Serialize Date #26622
Merged
[Flight] Serialize Date #26622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
reviewed
Apr 18, 2023
| key: string, | ||
| value: ReactClientValue, | ||
| ): ReactJSONValue { | ||
| if (typeof value === 'string' && value[value.length - 1] === 'Z') { |
Collaborator
There was a problem hiding this comment.
Let's see if we can find a way not to duplicate this check. We have a string check further below, that can maybe unify with this. Since that is also going to check the first character both operations are free.
However, this technique doesn't seem very proof for other types of values. We don't have immediate plans to support URL but it's often requested - and it has a toJSON too.
Another thing we could do is always operate on the original value. Might make it more future proof. E.g. FormData doesn't have toJSON today but it might in the future. This might be bad for perf since it's a mega-morphic key look up for every value.
Collaborator
Author
There was a problem hiding this comment.
How's this? ¯\_(ツ)_/¯ LMK if you prefer always reading the original value. (At that point it might be faster to reimplement JSON.stringify?)
sebmarkbage
reviewed
Apr 19, 2023
This is kind of annoying because Date implements toJSON so JSON.stringify turns it into a string before calling our replacer function.
sebmarkbage
approved these changes
Apr 19, 2023
kassens
pushed a commit
that referenced
this pull request
Apr 21, 2023
This is kind of annoying because Date implements toJSON so JSON.stringify turns it into a string before calling our replacer function.
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
This is kind of annoying because Date implements toJSON so JSON.stringify turns it into a string before calling our replacer function.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
This is kind of annoying because Date implements toJSON so JSON.stringify turns it into a string before calling our replacer function. DiffTrain build for commit c6db19f.
unstubbable
added a commit
to unstubbable/react
that referenced
this pull request
Sep 26, 2025
Using a similar approach as facebook#26622 for Date, we now allow URL instances to be transported via Flight. To make room for serializing URLs, which are prefixed with `'$u'`, we now use `'$_'` as the serialization for `undefined`, instead of `'$undefined'`. This also reduces the (uncompressed) RSC payload size a bit when lots of `undefined` values are transported.
unstubbable
added a commit
to unstubbable/react
that referenced
this pull request
Sep 26, 2025
Using a similar approach as facebook#26622 for Date, we now allow URL instances to be transported via Flight. To make room for serializing URLs, which are prefixed with `'$u'`, we now use `'$_'` as the serialization for `undefined`, instead of `'$undefined'`. This also reduces the (uncompressed) RSC payload size a bit when lots of `undefined` values are transported.
unstubbable
added a commit
to unstubbable/react
that referenced
this pull request
Sep 26, 2025
Previously, `URL` objects were serialized as plain strings via `JSON.stringify`, so they lost their class identity on the receiving side. This change extends Flight to transport `URL` instances directly, using an approach similar to facebook#26622 for `Date`. To make room for URL serialization (prefixed with `'$u'`), we now represent undefined as `'$_'` instead of `'$undefined'`. This also slightly reduces the uncompressed RSC payload size when many `undefined` values are transported. If Flight were the only concern, we could have used `'$U'` for URLs and kept the existing encoding for `undefined`. However, this would conflict with how `Uint8ClampedArray` is serialized in the Flight Reply Client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of annoying because Date implements toJSON so JSON.stringify turns it into a string before calling our replacer function.