Skip to content

[DevTools] Replace constructor.name checks with constructor checks #26567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[DevTools] Replace constructor.name checks with constructor checks #26567

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71f64ac
Replace constructor.name checks with instanceof
Apr 7, 2023
9706c5e
Replace instanceof checks with constructor checks
Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/react-devtools-shared/src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,11 +596,7 @@ export function getDataType(data: Object): DataType {
return hasOwnProperty.call(data.constructor, 'BYTES_PER_ELEMENT')
? 'typed_array'
: 'data_view';
} else if (data.constructor && data.constructor.name === 'ArrayBuffer') {
// HACK This ArrayBuffer check is gross; is there a better way?
// We could try to create a new DataView with the value.
// If it doesn't error, we know it's an ArrayBuffer,
// but this seems kind of awkward and expensive.
} else if (data.constructor && data.constructor === ArrayBuffer) {
return 'array_buffer';
} else if (typeof data[Symbol.iterator] === 'function') {
const iterator = data[Symbol.iterator]();
Expand All @@ -610,7 +606,7 @@ export function getDataType(data: Object): DataType {
} else {
return iterator === data ? 'opaque_iterator' : 'iterator';
}
} else if (data.constructor && data.constructor.name === 'RegExp') {
} else if (data.constructor && data.constructor === RegExp) {
return 'regexp';
} else {
// $FlowFixMe[method-unbinding]
Expand Down