Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete "triangle" resuming fuzz tester #26508

Merged
merged 1 commit into from
Mar 29, 2023

Commits on Mar 29, 2023

  1. Delete "triangle" resuming fuzz tester

    This deletes the ReactIncrementalTriangle test suite, which I originally
    added back in 2017 when I was working on Fiber's "resuming" feature. It
    was meant to simulate a similar scenario as Seb's "Sierpinski Triangle"
    Fiber demo.
    
    We eventually ended up removing resuming, but we kept this fuzz tester
    around since it wasn't really harming anything. However, over the years,
    we've had to make many small tweaks to decouple it from implementation
    details, to the point that it doesn't test anything useful anymore. And
    the thing that it originally tested has long since been removed.
    
    If or when we do add back resuming, we would write a different fuzz
    tester from scratch rather than build on this one.
    
    So rather than continue to contrive ways to prevent it from breaking, I
    propose we delete it.
    
    We still have other fuzz testers for things like Suspense and context
    propagation. Only this particular one has outlived its usefulness.
    acdlite committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    80d97be View commit details
    Browse the repository at this point in the history