Skip to content

Conversation

rickhanlonii
Copy link
Member

No description provided.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 16, 2023
@rickhanlonii rickhanlonii force-pushed the rh/fix-hydrate-tests branch from 6555c74 to 9f13afc Compare March 16, 2023 17:16
@rickhanlonii rickhanlonii force-pushed the rh/fix-hydrate-tests branch from 9f13afc to 498f0f8 Compare March 16, 2023 17:18
@kassens
Copy link
Member

kassens commented Mar 16, 2023

Thanks for fixing!

@react-sizebot
Copy link

Comparing: 480aa77...5057ebc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 157.44 kB 157.44 kB = 50.16 kB 50.15 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 159.03 kB 159.03 kB = 50.67 kB 50.67 kB
facebook-www/ReactDOM-prod.classic.js = 541.21 kB 541.21 kB = 96.41 kB 96.41 kB
facebook-www/ReactDOM-prod.modern.js = 525.20 kB 525.20 kB = 93.95 kB 93.95 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 5057ebc

@rickhanlonii
Copy link
Member Author

This probably isn't the right approach, if we want to remove hydrate we'll need to update all the tests that are depending on it anyway. Closing because we're reverting to look into this a bit more #26413

@rickhanlonii rickhanlonii deleted the rh/fix-hydrate-tests branch March 16, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants