Own our fiddles so we can update them more easily #2639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Btw, I looked into using a gist or git repo for these instead. It's possible for that to work but only in a couple cases and definitely not for embeds. I was hoping to make it easier to keep things updated but this is the best we'll get for now. |
zpao
added a commit
that referenced
this pull request
Dec 3, 2014
Own our fiddles so we can update them more easily
zpao
added a commit
that referenced
this pull request
Dec 3, 2014
Own our fiddles so we can update them more easily
josephsavona
added a commit
that referenced
this pull request
May 15, 2024
Implements the optimization described in the previous PR: if we know that a scope's dependency will _always_ invalidate (it is not memoized and it is guaranteed to be a new object if the instruction executes, such as an array or object literal), then we can prune that scope. The invalidation is transitive: we track always-invalidating types from within scopes, and if their scope gets invalidated we prune downstream scope that depend on them. ## Test Plan Tested via #2639 - see https://fburl.com/everpaste/3e3hjpjs. 91 files change output due to reactive scopes which would always invalidate due to always invalidating dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fiddles in Thinking in React were using 0.5. That would have been fine on it's own but then #2491 came along and just updated the API usage without updating the version. And then the base fiddle were @vjeux's. This brings them all under one roof and then we can share responsibility for updating.