Separate EventPriority from Lane #25460
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
This was referenced Oct 11, 2022
bsv-khanhpn
reviewed
Nov 2, 2022
| @@ -80,3 +83,13 @@ export function lanesToEventPriority(lanes: Lanes): EventPriority { | |||
| } | |||
| return IdleEventPriority; | |||
| } | |||
|
|
|||
| export function laneToEventPriority(lane: Lane): EventPriority { | |||
| if (lane === DefaultLane) { | |||
There was a problem hiding this comment.
@tyao1
Why don't you use switch here?
switch(lane) {
case DefaultLane:
return DefaultEventPriority;
case InputContinuousLane:
return ContinuousEventPriority;
default:
return (lane: any);
}
There was a problem hiding this comment.
They are the same. I would use switch if there were more cases to cover.
tyao1
force-pushed
the
ty-event-priorities-enum
branch
from
cfed715 to
96c7ce3
Compare
|
closing for now since we are starting with the other approach: #25700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breaks down #25438, we are going to merge Default and Continuous lane into Sync lane, so EventPriority no longer maps to Lane anymore.
How did you test this change?
yarn test
flow
lint