Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fizz/Float] Float for stylesheet resources #25243

Merged
merged 35 commits into from
Sep 30, 2022
Merged

[Fizz/Float] Float for stylesheet resources #25243

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
09c091d
[Fizz/Float] Float for stylesheet resources
gnoff Jun 10, 2022
589485d
determine preamble while flushing and make postamble resilient to asy…
gnoff Sep 28, 2022
b562d26
refactor render prep
gnoff Sep 28, 2022
ca98449
setCurrentlyRenderingBoundaryResources => setCurrentlyRenderingBounda…
gnoff Sep 28, 2022
72bbd2c
fixes
gnoff Sep 28, 2022
52b1388
add react-dom to fizz entry externals
gnoff Sep 28, 2022
d3bffc2
refactor default dispatcher initialization
gnoff Sep 28, 2022
24a8638
set default dispatcher in creatRoot and hydra
gnoff Sep 29, 2022
f06f1ad
clarify render start and stop function names
gnoff Sep 29, 2022
3793c2e
make TODO proper TODO and cleanup comments
gnoff Sep 29, 2022
16be133
integrate push/pop dispatcher with renderer prep / reset
gnoff Sep 29, 2022
0dc98d2
forks
gnoff Sep 29, 2022
9956a77
wip insertstyles
gnoff Sep 29, 2022
eec88a3
wip
gnoff Sep 29, 2022
e2bc267
wip fixes
gnoff Sep 29, 2022
0af21ba
query for existing styles in acquisition instead of construction. rem…
gnoff Sep 29, 2022
8da096c
revert to request based preamble
gnoff Sep 29, 2022
02984d7
cleanup style insertion scripts
gnoff Sep 29, 2022
52d2e66
lint
gnoff Sep 29, 2022
db245b0
remove rootDidFlush
gnoff Sep 29, 2022
4987d19
fix test
gnoff Sep 29, 2022
1dba4c0
remove extraneous preamableopen
gnoff Sep 29, 2022
3704af3
add react-dom external to flight entries
gnoff Sep 29, 2022
4d30694
types
gnoff Sep 30, 2022
33fa6e1
make insert style script slightly smaller
gnoff Sep 30, 2022
a0bf190
add react-dom externals
gnoff Sep 30, 2022
763fadc
fix double call of hasStyleResourceDependencies
gnoff Sep 30, 2022
3f3f9d5
remove special casing of precedence prop
gnoff Sep 30, 2022
f1925a8
escape hrefs in document queries
gnoff Sep 30, 2022
b845eff
use a stack for currentResources
gnoff Sep 30, 2022
7c45420
lints
gnoff Sep 30, 2022
17fde2c
flow
gnoff Sep 30, 2022
b544927
escape newline in attribute selector
gnoff Sep 30, 2022
5ebdce8
remove unecessary export
gnoff Sep 30, 2022
1ccdb00
nits
gnoff Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
nits
  • Loading branch information
@gnoff
gnoff committed Sep 30, 2022
commit 1ccdb0098465bc9bb2ac0c02f0c21204cb6a7e47
2 changes: 1 addition & 1 deletion packages/react-dom-bindings/src/client/ReactDOMFloatClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ type PreloadQualifyingProps = {
[string]: mixed,
};

// This function is called in complete work and we should always have a currentDocument set
// This function is called in begin work and we should always have a currentDocument set
export function getResource(
type: string,
pendingProps: Props,
Expand Down
3 changes: 1 addition & 2 deletions packages/react-dom-bindings/src/client/ReactDOMHostConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,8 +782,7 @@ function getNextHydratable(node) {
continue;
}
break;
}
if (nodeType === TEXT_NODE) {
} else if (nodeType === TEXT_NODE) {
break;
}
} else {
Expand Down