Skip to content

Conversation

@waldreiter
Copy link
Contributor

This resolves #2425.

Test plan: This was added to a webpage and it worked:

<form>
  <input name='text'/>
  <button
    formAction='anotherUrl.html'
    formEncType='multipart/form-data'
    formMethod='POST'
    formTarget='_blank'
  >
    Submit
  </button>
</form>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the supported elements section, attributes are farther down :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And actually, you can just leave off updating the docs. We do it a bit inconsistently but always update them right before release so we'll make sure they get updated manually then.

@waldreiter
Copy link
Contributor Author

@zpao Oops! I have removed the changes from the docs now.

@zpao
Copy link
Member

zpao commented Dec 5, 2014

Thanks! Sorry for the delay.

zpao added a commit that referenced this pull request Dec 5, 2014
Add Attributes formAction, formEncType, formMethod and formTarget
@zpao zpao merged commit dd844bf into facebook:master Dec 5, 2014
@zpao zpao added this to the 0.12.2 milestone Dec 5, 2014
zpao added a commit to zpao/react that referenced this pull request Dec 18, 2014
Add Attributes formAction, formEncType, formMethod and formTarget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some HTML5 attribute of button are not supported

2 participants