Add strokeOpacity to unitless CSS properties #2482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,6 +26,7 @@ var isUnitlessNumber = { | |||
| opacity: true, | |||
| order: true, | |||
| orphans: true, | |||
| strokeOpacity: true, | |||
There was a problem hiding this comment.
Yea, we should do this. Can you actually add it last in the list and put a comment mentioning that it's for SVG?
There was a problem hiding this comment.
We already have fillOpacity in the list.
BinaryMuse
force-pushed
the
bkt/fix-stroke-opacity
branch
from
ec2b721 to
96126e9
Compare
|
@zpao I've moved both the SVG-related properties to the bottom with a comment. |
sophiebits
added a commit
that referenced
this pull request
Nov 8, 2014
Add strokeOpacity to unitless CSS properties
|
Thank you! |
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Dec 18, 2014
Add strokeOpacity to unitless CSS properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.