Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools] devtools-test-shell Regression App fixes #24644

Merged
merged 1 commit into from
May 31, 2022
Merged

[DevTools] devtools-test-shell Regression App fixes #24644

merged 1 commit into from
May 31, 2022

Conversation

lunaruan
Copy link
Contributor

Made a couple of fixes to the devtools-test-shell

  • test selectors aren't available in > React v18.0 either, so we'll need to mock the test selector functions there as well
  • react-dom/client should map to react-dom/client and not react-dom

@lunaruan lunaruan requested review from bvaughn and mondaychen May 31, 2022 19:32
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 31, 2022
@lunaruan lunaruan merged commit b1858b1 into facebook:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mondaychen mondaychen mondaychen approved these changes

@bvaughn bvaughn Awaiting requested review from bvaughn

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lunaruan @mondaychen @facebook-github-bot