Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] Fix moduleNameMapper Order in DevTools Config #24602

Merged
merged 1 commit into from
May 23, 2022

Conversation

lunaruan
Copy link
Contributor

We need the regression config moduleNameMapper to come before the current moduleNameMapper so when it tries to map "/^react-dom\/([^/]+)$/ it doesn't get confused.

@lunaruan lunaruan requested review from bvaughn and mondaychen May 23, 2022 19:42
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 23, 2022
@sizebot
Copy link

sizebot commented May 23, 2022

Comparing: 210fee4...e4e11ee

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.49 kB 131.49 kB = 42.14 kB 42.14 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.75 kB 136.75 kB = 43.70 kB 43.70 kB
facebook-www/ReactDOM-prod.classic.js = 441.13 kB 441.13 kB = 80.41 kB 80.41 kB
facebook-www/ReactDOM-prod.modern.js = 426.42 kB 426.42 kB = 78.24 kB 78.24 kB
facebook-www/ReactDOMForked-prod.classic.js = 441.13 kB 441.13 kB = 80.41 kB 80.41 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against e4e11ee

Copy link
Contributor

@mondaychen mondaychen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lunaruan lunaruan merged commit 1e98682 into facebook:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants