Skip to content

Fork dispatch function based on the flag #22852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Dec 2, 2021

Purely refactoring, no functional changes.

This is pretty much extracted from #22680. No functional changes, it's copy pasta + pruning false branches. The goal is to trim down #22680 to the functional change.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 2, 2021
@sizebot
Copy link

sizebot commented Dec 2, 2021

Comparing: ea5a413...3e65b55

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 130.16 kB 130.16 kB +0.02% 41.61 kB 41.62 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 134.91 kB 134.92 kB = 43.00 kB 43.00 kB
facebook-www/ReactDOM-prod.classic.js +0.38% 425.60 kB 427.20 kB +0.16% 78.32 kB 78.44 kB
facebook-www/ReactDOM-prod.modern.js +0.39% 414.16 kB 415.76 kB +0.21% 76.63 kB 76.79 kB
facebook-www/ReactDOMForked-prod.classic.js +0.38% 425.60 kB 427.20 kB +0.16% 78.32 kB 78.45 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOM-prod.modern.js +0.39% 414.16 kB 415.76 kB +0.21% 76.63 kB 76.79 kB
facebook-www/ReactDOMForked-prod.modern.js +0.39% 414.16 kB 415.76 kB +0.21% 76.63 kB 76.79 kB
facebook-www/ReactDOM-prod.classic.js +0.38% 425.60 kB 427.20 kB +0.16% 78.32 kB 78.44 kB
facebook-www/ReactDOMForked-prod.classic.js +0.38% 425.60 kB 427.20 kB +0.16% 78.32 kB 78.45 kB
facebook-www/ReactDOM-profiling.modern.js +0.36% 445.99 kB 447.59 kB +0.19% 82.05 kB 82.21 kB
facebook-www/ReactDOMForked-profiling.modern.js +0.36% 445.99 kB 447.59 kB +0.19% 82.05 kB 82.21 kB
facebook-www/ReactDOM-profiling.classic.js +0.35% 457.48 kB 459.08 kB +0.16% 83.76 kB 83.90 kB
facebook-www/ReactDOMForked-profiling.classic.js +0.35% 457.48 kB 459.08 kB +0.16% 83.77 kB 83.90 kB
facebook-www/ReactDOMForked-dev.modern.js +0.22% 1,096.83 kB 1,099.27 kB +0.03% 243.31 kB 243.39 kB
facebook-www/ReactDOM-dev.modern.js +0.22% 1,096.83 kB 1,099.27 kB +0.03% 243.31 kB 243.39 kB
facebook-www/ReactDOMForked-dev.classic.js +0.22% 1,120.95 kB 1,123.40 kB +0.03% 248.11 kB 248.19 kB
facebook-www/ReactDOM-dev.classic.js +0.22% 1,120.95 kB 1,123.40 kB +0.03% 248.11 kB 248.19 kB

Generated by 🚫 dangerJS against 3e65b55

@gaearon gaearon force-pushed the fork-evt-logic branch 2 times, most recently from 6f2a863 to 0005d8f Compare December 2, 2021 01:03
@gaearon gaearon merged commit e737ea9 into facebook:main Dec 2, 2021
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
* Fork function based on a flag

* Prune false branches

Co-authored-by: Marco Salazar <salazarm@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants