Point to Flux site for Flux docs #2236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2014
| - id: flux-overview | ||
| title: Flux Overview | ||
| - id: flux-todo-list | ||
| title: Flux TodoMVC Tutorial |
There was a problem hiding this comment.
No way to get offsite links into the nav? This is a bit of a bummer. I'd rather be making more connections between React, Flux, Jest, etc rather than less.
|
I'm working on an external link solution for Jekyll / Liquid, if that's okay with you. |
|
I think you can edit the template directly in docs/_includes/nav_docs.html. |
This doesn't actually remove the pages, just the main content. Sidebar items now link offsite. The pages doesn't automatically redirect, but we could do that if we really wanted. Fixes facebook#2229
|
@fisherwebdev beat you to it :) The sidebar can now link offsite or really to any hard-coded URL. I put the flux links back in there. |
| end | ||
| end | ||
|
|
||
| Liquid::Template.register_filter(Jekyll::SidebarItemFilter) |
There was a problem hiding this comment.
sweet solution here! much cleaner.
fisherwebdev
added a commit
that referenced
this pull request
Sep 26, 2014
fisherwebdev
added a commit
that referenced
this pull request
Sep 29, 2014
Conflicts: docs/docs/flux-todo-list.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't actually remove the pages, just the main content and the
links in the sidebar. This doesn't automatically redirect, but we could
do that if we really wanted.
Fixes #2229