-
Notifications
You must be signed in to change notification settings - Fork 47.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add named hooks support to react-devtools-inline #22263
Merged
bvaughn
merged 8 commits into
facebook:main
from
bvaughn:devtools-dynamic-import-suspense-cache
Sep 9, 2021
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
08c3fcb
Added named hooks feature flag to DevToolsFeatureFlags
06fab2d
Added new dynamic import suspense cache
b941b03
Added hookNames entrypoint to react-devtools-inline
398dacd
Removed named hooks prefetch step since we are using cached network r…
f4c7df5
Added TODO to follow up on HookNamesModuleLoader param
22d2eb2
Fixed incorrect path in dynamic import()
7c8609d
Added instructions to react-devtools-inline README for new import() f…
e89d47d
Replaced test shell Webpack 'cheap-module-eval-source-map' source-map…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added instructions to react-devtools-inline README for new import() f…
…actory function
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the dynamic webpack public path override also necessary to get this working in OSS or is that something that's only necessary in
react-devtools-shell
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I'm not sure. Maybe it depends on which version of Webpack other projects are using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If #22267 doesn't land, should we add that as a note in the README as well? It feels a bit unintuitive for developers otherwise (it definitely was for us 😅)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah...let's see what happens 😅 I'm not a Webpack expert so maybe there's a better way to do this than what I did.
TBH I don't think anyone (other than us, Code Sandbox, and Replay.io) uses the inline package.