ESlint plugin is broken on 7.32.0 - Missing hasSuggestions

[dannyvassallo]

Summary

I kept hitting this error after upgrading to ESlint 7.32.0 whenever reaching a hook that had a suggestion.

Oops! Something went wrong! :(

ESLint: 7.32.0

Error: Rules with suggestions must set the `meta.hasSuggestions` property to `true`.

Test Plan

I've updated the meta entry and used it in my own project. Lint completes successfully.
I've also updated the Eslint version in this project.

[facebook-github-bot]

Hi @dannyvassallo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[sizebot]

Comparing: ecd73e1...dc0f42d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	127.58 kB	127.58 kB	=	40.72 kB	40.72 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	130.40 kB	130.40 kB	=	41.65 kB	41.65 kB
facebook-www/ReactDOM-prod.classic.js	=	405.16 kB	405.16 kB	=	75.04 kB	75.04 kB
facebook-www/ReactDOM-prod.modern.js	=	393.72 kB	393.72 kB	=	73.32 kB	73.32 kB
facebook-www/ReactDOMForked-prod.classic.js	=	405.16 kB	405.16 kB	=	75.05 kB	75.04 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against dc0f42d

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[dannyvassallo]

@bvaughn sorry to ping you directly but is there something I need to do to improve this PR or get a review? It's becoming an issue for my team and I'd hate to have to rollback our ESlint update. Thank you so much for your time!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[bvaughn]

@gaearon would be the best person to review this so I'm going to tag him. If he doesn't have time, I can take a stab at it. I just don't have much context.

[dannyvassallo]

@gaearon would be the best person to review this so I'm going to tag him. If he doesn't have time, I can take a stab at it. I just don't have much context.

Thank you both!

[dannyvassallo]

@gaearon It turns out we were using a branch on ESLint that introduced this bug. I can remove the version updates to ESLint here and leave just the hasSuggestions property if you'd like to merge it in anticipation of the breaking change to come in version 8.0.0.

Additionally I can add this rule: https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/require-meta-has-suggestions.md

Please let me know how I can be of assistance. Thank you!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!