[WIP] Possible work loop bugfix #22007
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
acdlite
force-pushed
the
possible-workloop-bugfix
branch
from
a298d0a
to
6058911
Compare
|
Comparing: 4225133...7a67816 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
rickhanlonii
reviewed
Aug 2, 2021
| @@ -752,6 +752,7 @@ function performConcurrentWorkOnRoot(root, didTimeout) { | |||
| return null; | |||
| } else { | |||
| // Current task was not canceled. Continue. | |||
| originalCallbackNode = root.callbackNode; | |||
There was a problem hiding this comment.
What am I missing?
This seems semantically the same since we only set it if root.callbackNode === originalCallbackNode
There was a problem hiding this comment.
Sigh you're not missing anything, I pushed the wrong commit 🤦♂️
rickhanlonii
approved these changes
Aug 2, 2021
acdlite
force-pushed
the
possible-workloop-bugfix
branch
from
6058911
to
013d7fe
Compare
|
I don't think this is the culprit but there's definitely something fishy going on with continuations so I'm going to use this branch to debug |
acdlite
force-pushed
the
possible-workloop-bugfix
branch
from
013d7fe
to
7a67816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a non-reproducible bug report internally. Based on the info in the bug report, I think it might be related to this code here.
The original code is definitely wrong but I don't know if it's the same bug that's being reported.
Pushing this so we can try it and see. Will try to write a test and land the fix regardless.