0.11.2 stuff #2198
Merged
0.11.2 stuff #2198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis ran into some problems, hopefully this fixes it.
(cherry picked from commit 808730d) Conflicts: vendor/fbtransform/visitors.js
|
|
||
| * Update `esprima` and `jstransform` for correctness fixes | ||
| * The `jsx` executable now exposes a `--strip-types` flag which can be used to remove Typescript-like type annotations | ||
| * This option is also exposed to `require('react-tools').transform` |
There was a problem hiding this comment.
"…as `stripTypes" maybe?
|
lgtm |
TODO: starter kit for cherry-pick to master
|
I was a little confused about this: Is this to support the use of TypeScript directly? |
|
@gurdasnijor As I understood it it's for "Flow", its type annotations look like TypeScript. |
|
@syranide Not me bro. =] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ DO NOT MERGE ❗, I'll just push all of this directly, and I still need to amend with the starter kit before that happens.
any last minute feeback? These are the last bits of #2137