Skip to content

Merge /unstable-fizz entry point into /server #21684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Jun 15, 2021

The new APIs like pipeToNodeWritable will end up on the react-dom/server entry point but we still want to support the legacy APIs on this same entry point to make it easy to upgrade.

This changes the /server entry point in src to lazily import the correct src file. That way we can pick the right configs depending on which entry point is tested during that test.

The npm entry point merges the two bundles in the exports.

Once we move to ESM, DCE can strip one of them out.

@sebmarkbage sebmarkbage requested a review from gaearon June 15, 2021 01:06
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 15, 2021
@sizebot
Copy link

sizebot commented Jun 15, 2021

Comparing: 9343f87...d7d2dbf

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.08 kB 127.08 kB = 40.74 kB 40.74 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.89 kB 129.89 kB = 41.67 kB 41.67 kB
facebook-www/ReactDOM-prod.classic.js = 405.00 kB 405.00 kB = 74.92 kB 74.92 kB
facebook-www/ReactDOM-prod.modern.js = 393.35 kB 393.35 kB = 73.10 kB 73.10 kB
facebook-www/ReactDOMForked-prod.classic.js = 405.00 kB 405.00 kB = 74.92 kB 74.92 kB
oss-experimental/react-dom/server.browser.js +171.90% 0.24 kB 0.66 kB +54.27% 0.16 kB 0.25 kB
oss-stable-semver/react-dom/server.browser.js +171.90% 0.24 kB 0.66 kB +54.27% 0.16 kB 0.25 kB
oss-stable/react-dom/server.browser.js +171.90% 0.24 kB 0.66 kB +54.27% 0.16 kB 0.25 kB
oss-experimental/react-dom/server.node.js +170.34% 0.24 kB 0.64 kB +57.41% 0.16 kB 0.26 kB
oss-stable-semver/react-dom/server.node.js +170.34% 0.24 kB 0.64 kB +57.41% 0.16 kB 0.26 kB
oss-stable/react-dom/server.node.js +170.34% 0.24 kB 0.64 kB +57.41% 0.16 kB 0.26 kB
oss-experimental/react-dom/unstable-fizz.browser.js Deleted 0.23 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-experimental/react-dom/unstable-fizz.js Deleted 0.07 kB 0.00 kB Deleted 0.09 kB 0.00 kB
oss-experimental/react-dom/unstable-fizz.node.js Deleted 0.22 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react-dom/unstable-fizz.browser.js Deleted 0.23 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react-dom/unstable-fizz.js Deleted 0.07 kB 0.00 kB Deleted 0.09 kB 0.00 kB
oss-stable-semver/react-dom/unstable-fizz.node.js Deleted 0.22 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react-dom/unstable-fizz.browser.js Deleted 0.23 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react-dom/unstable-fizz.js Deleted 0.07 kB 0.00 kB Deleted 0.09 kB 0.00 kB
oss-stable/react-dom/unstable-fizz.node.js Deleted 0.22 kB 0.00 kB Deleted 0.16 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/server.browser.js +171.90% 0.24 kB 0.66 kB +54.27% 0.16 kB 0.25 kB
oss-stable-semver/react-dom/server.browser.js +171.90% 0.24 kB 0.66 kB +54.27% 0.16 kB 0.25 kB
oss-stable/react-dom/server.browser.js +171.90% 0.24 kB 0.66 kB +54.27% 0.16 kB 0.25 kB
oss-experimental/react-dom/server.node.js +170.34% 0.24 kB 0.64 kB +57.41% 0.16 kB 0.26 kB
oss-stable-semver/react-dom/server.node.js +170.34% 0.24 kB 0.64 kB +57.41% 0.16 kB 0.26 kB
oss-stable/react-dom/server.node.js +170.34% 0.24 kB 0.64 kB +57.41% 0.16 kB 0.26 kB
oss-experimental/react-dom/unstable-fizz.browser.js Deleted 0.23 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-experimental/react-dom/unstable-fizz.js Deleted 0.07 kB 0.00 kB Deleted 0.09 kB 0.00 kB
oss-experimental/react-dom/unstable-fizz.node.js Deleted 0.22 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react-dom/unstable-fizz.browser.js Deleted 0.23 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable-semver/react-dom/unstable-fizz.js Deleted 0.07 kB 0.00 kB Deleted 0.09 kB 0.00 kB
oss-stable-semver/react-dom/unstable-fizz.node.js Deleted 0.22 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react-dom/unstable-fizz.browser.js Deleted 0.23 kB 0.00 kB Deleted 0.16 kB 0.00 kB
oss-stable/react-dom/unstable-fizz.js Deleted 0.07 kB 0.00 kB Deleted 0.09 kB 0.00 kB
oss-stable/react-dom/unstable-fizz.node.js Deleted 0.22 kB 0.00 kB Deleted 0.16 kB 0.00 kB

Generated by 🚫 dangerJS against d7d2dbf

@sebmarkbage sebmarkbage merged commit 9212d99 into facebook:master Jun 15, 2021
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants