Skip to content

Ensure sync-xhr is allowed before reload and profile #20879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 11, 2021
+58 −9
Merged

Ensure sync-xhr is allowed before reload and profile #20879

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f3ad480
ensure sync-xhr is allowed before reload and profile
ChrisDobby Feb 21, 2021
8431649
fix flow errors
ChrisDobby Feb 25, 2021
e3e2bc4
remove unused import
ChrisDobby Feb 25, 2021
9315f92
always make reload and profile disabled when sync-xhr is not available
ChrisDobby Feb 26, 2021
9665d7e
ensure window.document is truthy when checking feature policy
ChrisDobby Mar 9, 2021
b10523a
Added an inline comment.
bvaughn Mar 11, 2021
3648db2
Convert isSynchronousXHRSupported to boolean explicitly
bvaughn Mar 11, 2021
fea90f7
Store supportsReloadAndProfile getter also considers isSynchronousXHR…
bvaughn Mar 11, 2021
49edee7
Reverted change to ReloadAndProfileButton tooltip.
bvaughn Mar 11, 2021
1df7ab1
Alpha sort nit
bvaughn Mar 11, 2021
df07a8d
Removed no-longer-used isSynchronousXHRSupported getter
bvaughn Mar 11, 2021
92c6cae
Updating agent.js again
bvaughn Mar 11, 2021
2310a7d
Oops removed 'isSynchronousXHRSupported' from EventEmitter config
bvaughn Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added an inline comment.
  • Loading branch information
@bvaughn
bvaughn authored Mar 11, 2021
commit b10523abae73057fe1e2ec6b52f8d338d78fedbe
4 changes: 3 additions & 1 deletion packages/react-devtools-shared/src/backend/agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ import type {
RendererInterface,
} from './types';
import type {ComponentFilter} from '../types';
import {isSynchronousXHRSupported} from './utils';
import {
} from './utils';

const debug = (methodName, ...args) => {
if (__DEBUG__) {
Expand Down Expand Up @@ -216,6 +217,7 @@ export default class Agent extends EventEmitter<{|

// Notify the frontend if the backend supports the Storage API (e.g. localStorage).
// If not, features like reload-and-profile will not work correctly and must be disabled.
// The same goes for sync XHR requests; it's how DevTools injects before ReactDOM starts rendering.
let isBackendStorageAPISupported = false;
try {
localStorage.getItem('test');
Expand Down