Skip to content

Retry with fresh otp if publish fails #20582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jan 13, 2021

Currently, if publishing a package fails, the script crashes, and the user must start it again from the beginning. Usually this happens because the one-time password has timed out.

With this change, the user will be prompted for a fresh otp, and the script will resume publishing.

Currently, if publishing a package fails, the script crashes, and the
user must start it again from the beginning. Usually this happens
because the one-time password has timed out.

With this change, the user will be prompted for a fresh otp, and the
script will resume publishing.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 13, 2021
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easier than I expected

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 17ec8b4:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jan 13, 2021

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 17ec8b4

@sizebot
Copy link

sizebot commented Jan 13, 2021

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 17ec8b4

@acdlite acdlite merged commit fc07b07 into facebook:master Jan 13, 2021
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Currently, if publishing a package fails, the script crashes, and the
user must start it again from the beginning. Usually this happens
because the one-time password has timed out.

With this change, the user will be prompted for a fresh otp, and the
script will resume publishing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants