DevTools: Improve browser extension iframe support #19827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevTools: Iframe support
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 554ea7e:
|
ghost
approved these changes
Sep 13, 2020
bvaughn
approved these changes
Sep 14, 2020
| } | ||
|
|
||
| function isMainWindow(targetWindow: any): boolean { | ||
| return targetWindow.self === targetWindow.top; |
There was a problem hiding this comment.
Why window.self rather than just window?
There was a problem hiding this comment.
It is the same but self can work with worker(it is more flexible)
There was a problem hiding this comment.
Ok just wanted to confirm I wasn't missing anything. 😄
|
Thank you @bvaughn ! |
|
Looks like this change broke the development test harness. To repro:
I think I'm going to have to revert it for now. Any interest in looking back into it @omarsy? |
Merged
|
ok @bvaughn I'm looking it |
bvaughn
pushed a commit
that referenced
this pull request
Sep 17, 2020
todortotev
pushed a commit
to todortotev/react
that referenced
this pull request
Sep 18, 2020
Co-authored-by: Joel DSouza <joel.dsouza@kapturecrm.com> Co-authored-by: Damien Maillard <damien.maillard@dailymotion.com> Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com>
todortotev
pushed a commit
to todortotev/react
that referenced
this pull request
Sep 18, 2020
…19827)" (facebook#19852) This reverts commit ec39a5e.
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Joel DSouza <joel.dsouza@kapturecrm.com> Co-authored-by: Damien Maillard <damien.maillard@dailymotion.com> Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com>
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
…19827)" (facebook#19852) This reverts commit ec39a5e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull requests is intended to improve iframe support for devtools browser extensions(#18945), without add a code to pass the hook through from the parent.
Test Plan