Scheduling Profiler: Add Fast Refresh #19757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4c84e9d:
|
kartikcho
reviewed
Sep 3, 2020
|
Ah, I forgot #19707 is implementing what I suggested, my bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The scheduling profiler currently reloads when code is changed, dumping any loaded data and bringing us back to the import page. This is a pain in dev, especially when iterating on canvas code.
Before:
After:
cc @bvaughn, @kartikcho
Test Plan
yarn build-for-devtoolsnow also builds react-refreshyarn buildbuilds without crashing. Built app verified to work withcd dist && npx serveyarn start(see screen recording above)