fix: synchronize focused email input on blur to avoid check validity when inputting#19621
Closed
jameslahm wants to merge 3 commits intofacebook:masterfrom
jameslahm:master
Closed
fix: synchronize focused email input on blur to avoid check validity when inputting#19621jameslahm wants to merge 3 commits intofacebook:masterfrom jameslahm:master
jameslahm wants to merge 3 commits intofacebook:masterfrom
jameslahm:master
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d6d1193:
|
Collaborator
|
Thanks for the PR. Turns out we already had this fix in #18379 and I reverted in #18459 because it's a behavior change and a bit risky without thorough testing. We want to keep changes in 17 minimal so this would be better to do in 18. That said, I'm also hearing this is being fixed in Chrome: #15418 (comment). |
Collaborator
|
(I'm closing because we can reapply the past PR once we're comfortable with the change) |
Author
|
Thanks for the reply, get it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #19563, similar to #7253. The reproduce shows that the cursor will skip to the beginning position of the email input when delete with backspace. The cause is that
node.defaultValuewill be set to thenode.valuewhen inputting, which triggers validation on the email input and make the cursor skip to the beginning position in blink. So similar to focused number input #7359, synchronize focused email input on blur, which should works.Test Plan
The reproduce show it works