Speed up yarn installs in circle builds #19566
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,17 +7,11 @@ aliases: | |
| - &environment | ||
| TZ: /usr/share/zoneinfo/America/Los_Angeles | ||
|
|
||
| - &restore_node_modules | ||
| restore_cache: | ||
| name: Restore node_modules cache | ||
| keys: | ||
|
There was a problem hiding this comment. Removing this alias because a yarn install should only be necessary in the |
||
| - v2-node-{{ arch }}-{{ .Branch }}-{{ checksum "yarn.lock" }}-node-modules | ||
|
|
||
| - &TEST_PARALLELISM 20 | ||
|
|
||
|
|
@@ -30,8 +24,7 @@ aliases: | |
| steps: | ||
| - checkout | ||
| - attach_workspace: *attach_workspace | ||
| - *restore_node_modules | ||
| - run: node ./scripts/rollup/consolidateBundleSizes.js | ||
| - run: ./scripts/circleci/pack_and_store_artifact.sh | ||
| - store_artifacts: | ||
|
|
@@ -59,22 +52,37 @@ jobs: | |
| - run: | ||
| name: Nodejs Version | ||
| command: node --version | ||
| - restore_cache: | ||
| name: Restore yarn cache | ||
| key: v2-node-{{ arch }}-{{ checksum "yarn.lock" }}-yarn | ||
| - run: | ||
| name: Install Packages | ||
| command: yarn --frozen-lockfile --cache-folder ~/.cache/yarn | ||
| - save_cache: | ||
| # Store the yarn cache globally for all lock files with this same | ||
| # checksum. This will speed up the setup job for all PRs where the | ||
| # lockfile is the same. | ||
| name: Save yarn cache for future installs | ||
| key: v2-node-{{ arch }}-{{ checksum "yarn.lock" }}-yarn | ||
| paths: | ||
| - ~/.cache/yarn | ||
| - save_cache: | ||
| # Store node_modules for all jobs in this workflow so that they don't | ||
| # need to each run a yarn install for each job. This will speed up | ||
| # all jobs run on this branch with the same lockfile. | ||
| name: Save node_modules cache | ||
| # This cache key is per branch, a yarn install in setup is required. | ||
| key: v2-node-{{ arch }}-{{ .Branch }}-{{ checksum "yarn.lock" }}-node-modules | ||
| paths: | ||
| - node_modules | ||
|
There was a problem hiding this comment. We're now saving two different caches:
The There was a problem hiding this comment. I think this needs to be modified to also save nested |
||
|
|
||
| yarn_lint: | ||
| docker: *docker | ||
| environment: *environment | ||
|
|
||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: node ./scripts/prettier/index | ||
| - run: node ./scripts/tasks/eslint | ||
| - run: ./scripts/circleci/check_license.sh | ||
|
|
@@ -87,8 +95,7 @@ jobs: | |
|
|
||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: node ./scripts/tasks/flow-ci | ||
|
|
||
| RELEASE_CHANNEL_stable_yarn_test: | ||
|
|
@@ -98,8 +105,7 @@ jobs: | |
|
|
||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=stable --ci | ||
|
|
||
| yarn_test: | ||
|
|
@@ -108,8 +114,7 @@ jobs: | |
| parallelism: *TEST_PARALLELISM | ||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: yarn test --ci | ||
|
|
||
| RELEASE_CHANNEL_stable_yarn_test_www: | ||
|
|
@@ -118,8 +123,7 @@ jobs: | |
| parallelism: *TEST_PARALLELISM | ||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=www-classic --ci | ||
|
|
||
| RELEASE_CHANNEL_stable_yarn_test_www_variant: | ||
|
|
@@ -128,8 +132,7 @@ jobs: | |
| parallelism: *TEST_PARALLELISM | ||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=www-classic --variant --ci | ||
|
|
||
| RELEASE_CHANNEL_stable_yarn_test_prod_www: | ||
|
|
@@ -138,8 +141,7 @@ jobs: | |
| parallelism: *TEST_PARALLELISM | ||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=www-classic --prod --ci | ||
|
|
||
| RELEASE_CHANNEL_stable_yarn_test_prod_www_variant: | ||
|
|
@@ -148,8 +150,7 @@ jobs: | |
| parallelism: *TEST_PARALLELISM | ||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=www-classic --prod --variant --ci | ||
|
|
||
| yarn_test_www: | ||
|
|
@@ -158,8 +159,7 @@ jobs: | |
| parallelism: *TEST_PARALLELISM | ||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=www-modern --ci | ||
|
|
||
| yarn_test_www_variant: | ||
|
|
@@ -168,8 +168,7 @@ jobs: | |
| parallelism: *TEST_PARALLELISM | ||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=www-modern --variant --ci | ||
|
|
||
| yarn_test_prod_www: | ||
|
|
@@ -178,8 +177,7 @@ jobs: | |
| parallelism: *TEST_PARALLELISM | ||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=www-modern --prod --ci | ||
|
|
||
| yarn_test_prod_www_variant: | ||
|
|
@@ -188,8 +186,7 @@ jobs: | |
| parallelism: *TEST_PARALLELISM | ||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=www-modern --prod --variant --ci | ||
|
|
||
| RELEASE_CHANNEL_stable_yarn_test_persistent: | ||
|
|
@@ -199,8 +196,7 @@ jobs: | |
|
|
||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=stable --persistent --ci | ||
|
|
||
| RELEASE_CHANNEL_stable_yarn_test_prod: | ||
|
|
@@ -210,8 +206,7 @@ jobs: | |
|
|
||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=stable --prod --ci | ||
|
|
||
| yarn_test_prod: | ||
|
|
@@ -220,8 +215,7 @@ jobs: | |
| parallelism: *TEST_PARALLELISM | ||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=experimental --prod --ci | ||
|
|
||
| RELEASE_CHANNEL_stable_yarn_build: | ||
|
|
@@ -230,8 +224,7 @@ jobs: | |
| parallelism: *TEST_PARALLELISM | ||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: | ||
| environment: | ||
| RELEASE_CHANNEL: stable | ||
|
|
@@ -257,8 +250,7 @@ jobs: | |
| parallelism: 20 | ||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: | ||
| environment: | ||
| RELEASE_CHANNEL: experimental | ||
|
|
@@ -285,8 +277,7 @@ jobs: | |
| steps: | ||
| - checkout | ||
| - attach_workspace: *attach_workspace | ||
| - *restore_node_modules | ||
| - run: | ||
| environment: | ||
| RELEASE_CHANNEL: experimental | ||
|
|
@@ -305,8 +296,7 @@ jobs: | |
| steps: | ||
| - checkout | ||
| - attach_workspace: *attach_workspace | ||
| - *restore_node_modules | ||
| # This runs in the process_artifacts job, too, but it's faster to run | ||
| # this step in both jobs instead of running the jobs sequentially | ||
| - run: node ./scripts/rollup/consolidateBundleSizes.js | ||
|
|
@@ -321,8 +311,7 @@ jobs: | |
| steps: | ||
| - checkout | ||
| - attach_workspace: *attach_workspace | ||
| - *restore_node_modules | ||
| # This runs in the process_artifacts job, too, but it's faster to run | ||
| # this step in both jobs instead of running the jobs sequentially | ||
| - run: node ./scripts/rollup/consolidateBundleSizes.js | ||
|
|
@@ -337,8 +326,7 @@ jobs: | |
| steps: | ||
| - checkout | ||
| - attach_workspace: *attach_workspace | ||
| - *restore_node_modules | ||
| - run: yarn lint-build | ||
| - run: scripts/circleci/check_minified_errors.sh | ||
|
|
||
|
|
@@ -348,8 +336,7 @@ jobs: | |
| steps: | ||
| - checkout | ||
| - attach_workspace: *attach_workspace | ||
| - *restore_node_modules | ||
| - run: | ||
| environment: | ||
| RELEASE_CHANNEL: stable | ||
|
|
@@ -363,8 +350,7 @@ jobs: | |
| steps: | ||
| - checkout | ||
| - attach_workspace: *attach_workspace | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=stable --build --ci | ||
|
|
||
| yarn_test_build: | ||
|
|
@@ -374,8 +360,7 @@ jobs: | |
| steps: | ||
| - checkout | ||
| - attach_workspace: *attach_workspace | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=experimental --build --ci | ||
|
|
||
| yarn_test_build_devtools: | ||
|
|
@@ -384,8 +369,7 @@ jobs: | |
| steps: | ||
| - checkout | ||
| - attach_workspace: *attach_workspace | ||
| - *restore_node_modules | ||
| - run: yarn test --project=devtools --build --ci | ||
|
|
||
| RELEASE_CHANNEL_stable_yarn_test_dom_fixtures: | ||
|
|
@@ -394,7 +378,7 @@ jobs: | |
| steps: | ||
| - checkout | ||
| - attach_workspace: *attach_workspace | ||
| - *restore_node_modules | ||
| - run: | ||
| name: Run DOM fixture tests | ||
| environment: | ||
|
|
@@ -410,8 +394,7 @@ jobs: | |
| environment: *environment | ||
| steps: | ||
| - checkout | ||
| - *restore_node_modules | ||
| - run: | ||
| name: Run fuzz tests | ||
| command: | | ||
|
|
@@ -425,8 +408,7 @@ jobs: | |
| steps: | ||
| - checkout | ||
| - attach_workspace: *attach_workspace | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=stable --build --prod --ci | ||
|
|
||
| yarn_test_build_prod: | ||
|
|
@@ -436,8 +418,7 @@ jobs: | |
| steps: | ||
| - checkout | ||
| - attach_workspace: *attach_workspace | ||
| - *restore_node_modules | ||
| - run: yarn test --release-channel=experimental --build --prod --ci | ||
|
|
||
| workflows: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to clarify what this is actually restoring, which is the
node_modulesdirectory now.