Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects list refactor continued: passive effects traversal #19374

Merged
merged 11 commits into from
Jul 29, 2020
Merged

Effects list refactor continued: passive effects traversal #19374

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bfe385f
Effects list refactor continued: passive effects traversal
Jul 22, 2020
fe2e311
Add persistent, Static subtreeTag
Jul 27, 2020
2876d61
Add static effectTag bit for passive effect cleanup after unmount
Jul 28, 2020
0c59d06
Added gate to SchedulingProfiler test
Jul 28, 2020
7d618ed
Defer Fiber field clenaup to passive phase for all but return pointer
Jul 29, 2020
cba61f7
Remove PassiveSubtreeTag optimization
Jul 29, 2020
9dc5188
Tweaks made in response to PR feedback:
Jul 29, 2020
a57840e
Defer clearing deletions array until passive, remove unecessary didBa…
Jul 29, 2020
6d926da
Removed PassiveUnmountPendingDev in the new reconciler
Jul 29, 2020
c1a1be5
Removed unnecessary bailout check. Added a TODO for followup.
Jul 29, 2020
ae37c7c
Split flushPassiveUnmountEffects() into two functions
Jul 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added gate to SchedulingProfiler test
  • Loading branch information
Brian Vaughn committed Jul 29, 2020
commit 0c59d069aae3c7d0654344cb10ae83c5c9cc3b24
67 changes: 45 additions & 22 deletions packages/react-reconciler/src/__tests__/SchedulingProfiler-test.internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,28 +486,51 @@ describe('SchedulingProfiler', () => {
ReactTestRenderer.create(<Example />, {unstable_isConcurrent: true});
});

expect(marks.map(normalizeCodeLocInfo)).toEqual([
'--schedule-render-512',
'--render-start-512',
'--render-stop',
'--commit-start-512',
'--layout-effects-start-512',
'--layout-effects-stop',
'--commit-stop',
'--passive-effects-start-512',
toggleComponentStacks(
'--schedule-state-update-1024-Example-\n in Example (at **)',
),
'--passive-effects-stop',
'--render-start-1024',
'--render-stop',
'--commit-start-1024',
'--layout-effects-start-1024',
'--layout-effects-stop',
'--commit-stop',
'--passive-effects-start-1024',
'--passive-effects-stop',
]);
gate(({old}) => {
if (old) {
expect(marks.map(normalizeCodeLocInfo)).toEqual([
'--schedule-render-512',
'--render-start-512',
'--render-stop',
'--commit-start-512',
'--layout-effects-start-512',
'--layout-effects-stop',
'--commit-stop',
'--passive-effects-start-512',
toggleComponentStacks(
'--schedule-state-update-1024-Example-\n in Example (at **)',
),
'--passive-effects-stop',
'--render-start-1024',
'--render-stop',
'--commit-start-1024',
'--commit-stop',
]);
} else {
expect(marks.map(normalizeCodeLocInfo)).toEqual([
'--schedule-render-512',
'--render-start-512',
'--render-stop',
'--commit-start-512',
'--layout-effects-start-512',
'--layout-effects-stop',
'--commit-stop',
'--passive-effects-start-512',
toggleComponentStacks(
'--schedule-state-update-1024-Example-\n in Example (at **)',
),
'--passive-effects-stop',
'--render-start-1024',
'--render-stop',
'--commit-start-1024',
'--layout-effects-start-1024',
'--layout-effects-stop',
'--commit-stop',
'--passive-effects-start-1024',
'--passive-effects-stop',
]);
}
});
});

// @gate enableSchedulingProfiler
Expand Down