Devtools: improve getID guard #19364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9587365:
|
bvaughn
approved these changes
Jul 15, 2020
|
Just to clarify, the place this check was strengthened only impacts v15 React, which FB would not be running. Still seems fine to do though :) |
|
@bvaughn Ah my bad. I'll take another look later at the other codepaths too :) |
|
Just FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I ran into an issue where I saw
invalid value used as weak map keywhen debugging an internal issue. Unfortunately, I wasn't able to reproduce it but looking through the code. However, I did notice there was a guard in the devtools code that could be strengthened, and thus helping narrow down a codepath that leads to us setting an invalid WeakMap key.