Use Lanes to check if a render is a Suspense retry #19307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Suspense retries have their own dedicated set of lanes (facebook#19287), we can determine if a render includes only retries by checking if its lanes are a subset of the retry lanes. Previously we inferred this by checking `workInProgressRootLatestProcessedEventTime`. If it's not set, that implies that no updates were processed in the current render, which implies it must be a Suspense retry. The eventual plan is to get rid of `workInProgressRootLatestProcessedEventTime` and instead track event times on the root; this change is one the steps toward that goal. The relevant tests were originally added in facebook#15769.
facebook-github-bot
added
CLA Signed
React Core Team
acdlite
commented
Jul 10, 2020
| @@ -451,9 +451,12 @@ export function getLanesToRetrySynchronouslyOnError(root: FiberRoot): Lanes { | |||
| export function returnNextLanesPriority() { | |||
| return return_highestLanePriority; | |||
| } | |||
| export function hasUpdatePriority(lanes: Lanes) { | |||
| export function includesNonIdleWork(lanes: Lanes) { | |||
There was a problem hiding this comment.
This rename is unrelated. Just felt slightly better than the old one.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e21e908:
|
Details of bundled changes.Comparing: 14084be...e21e908 react-dom
react-art
react-test-renderer
react-native-renderer
react-reconciler
Size changes (stable) |
Details of bundled changes.Comparing: 14084be...e21e908 react-dom
react-native-renderer
react-art
react-test-renderer
react-reconciler
Size changes (experimental) |
gaearon
approved these changes
Jul 10, 2020
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Jul 13, 2020
Same logic as facebook#19307. Uses RetryLanes instead of event time to determine if a render includes new updates.
acdlite
added a commit
that referenced
this pull request
Jul 13, 2020
Same logic as #19307. Uses RetryLanes instead of event time to determine if a render includes new updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Suspense retries have their own dedicated set of lanes (#19287), we can determine if a render includes only retries by checking if its lanes are a subset of the retry lanes.
Previously we inferred this by checking
workInProgressRootLatestProcessedEventTime. If it's not set, that implies that no updates were processed in the current render, which implies it must be a Suspense retry. The eventual plan is to get rid ofworkInProgressRootLatestProcessedEventTimeand instead track event times on the root; this change is one the steps toward that goal.The relevant tests were originally added in #15769.