Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Effects list refactor #19261

Closed
wants to merge 8 commits into from
Closed

Effects list refactor #19261

wants to merge 8 commits into from
+368 −233

Commits on Jul 11, 2020

  1. Effects list rewrite

    Brian Vaughn committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    d8f0b4a View commit details
    Browse the repository at this point in the history

  2. Improved deletions approach 

    Process deletions as we traverse the tree during commit, before we process other effects. This has the result of better mimicking the previous sequencing.
    Brian Vaughn committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    7d86cb9 View commit details
    Browse the repository at this point in the history

  3. Made deletions field nullable

    Brian Vaughn committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    28c7f50 View commit details
    Browse the repository at this point in the history

  4. Revert (no longer necessary) change to ReactNative test

    Brian Vaughn committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    eaba7c8 View commit details
    Browse the repository at this point in the history

  5. Eagerly set Deletions effect on Fiber when adding child to deletions … 

    …array
    Brian Vaughn committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    d34e3e5 View commit details
    Browse the repository at this point in the history

  6. Initialize deletions array to null

    Brian Vaughn committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    a5708e9 View commit details
    Browse the repository at this point in the history

  7. Null out deletions array instead of splicing 🤡

    Brian Vaughn committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    3ab5de1 View commit details
    Browse the repository at this point in the history

  8. Removed TODO comment

    Brian Vaughn committed Jul 11, 2020
    Configuration menu
    Copy the full SHA
    fed95cf View commit details
    Browse the repository at this point in the history