Bugfix: Infinite loop in beforeblur event #19053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the focused node is hidden by a Suspense boundary, we fire the beforeblur event. Our check for whether a tree is being hidden isn't specific enough. It should only fire when the tree is initially hidden, but it's being fired for updates, too.
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ec032c8:
|
Details of bundled changes.Comparing: 1d85bb3...ec032c8 react-dom
react-reconciler
Size changes (stable) |
Details of bundled changes.Comparing: 1d85bb3...ec032c8 react-dom
react-reconciler
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
Should only beforeblur fire if the node was previously visible. Not during updates to an already hidden tree. To optimize this, we should use a dedicated effect tag and mark it in the render phase. I've left this for a follow-up, though. Maybe can revisit after the planned refactor of the commit phase.
acdlite
changed the title
trueadm
reviewed
Jun 1, 2020
| @@ -333,13 +333,21 @@ export function findCurrentHostFiberWithNoPortals(parent: Fiber): Fiber | null { | |||
| return null; | |||
| } | |||
|
|
|||
| // This function detects when a Suspense boundary goes from visible to hidden. | |||
| // It returns false if the boundary is already hidden. | |||
| // TODO: Use an effect tag. And move this to ReactFiberCommitWork. | |||
| export function isFiberSuspenseAndTimedOut(fiber: Fiber): boolean { | |||
There was a problem hiding this comment.
This function is also used by Scopes for traversal, will this change affect that too? See:
There was a problem hiding this comment.
My mistake, didn't search for other uses.
I moved the logic into the commit phase.
isFiberSuspenseAndTimedOut is used elsewhere, so I inlined the commit logic into the commit phase itself.
acdlite
force-pushed
the
blur-infinite-loop
branch
2 times, most recently
from
954048d to
1f52fe2
Compare
trueadm
approved these changes
Jun 1, 2020
acdlite
force-pushed
the
blur-infinite-loop
branch
from
1f52fe2 to
ec032c8
Compare
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the focused node is hidden by a Suspense boundary, we fire the beforeblur event. Our check for whether a tree is being hidden isn't specific enough. It should only fire when the tree is initially hidden, but it's being fired for updates, too.
To optimize this, we should use a dedicated effect tag and mark it in the render phase. I've left this for a follow-up, though. Maybe can revisit after the planned refactor of the commit phase.