Skip to content

Clean up passive effects experimental flags #19021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2020
Merged

Clean up passive effects experimental flags #19021

merged 1 commit into from
May 28, 2020

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented May 27, 2020

Cleanup this experiment. It was a success and we'll roll it out in the upcoming major.

Resolves #17945.

@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels May 27, 2020
@bvaughn bvaughn changed the title Cleaned up passive effects experimental flags Clean up passive effects experimental flags May 27, 2020
@sizebot
Copy link

sizebot commented May 27, 2020

Details of bundled changes.

Comparing: b41beb1...a6ec644

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-dev.js +0.3% +0.3% 647.08 KB 649.23 KB 138.69 KB 139.09 KB RN_OSS_DEV
ReactNativeRenderer-dev.js +0.3% +0.3% 665.91 KB 667.99 KB 143.16 KB 143.58 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 🔺+0.4% 🔺+0.3% 272.46 KB 273.44 KB 47.05 KB 47.2 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js +0.3% +0.3% 284.51 KB 285.45 KB 49.35 KB 49.51 KB RN_OSS_PROFILING
ReactFabric-prod.js 🔺+0.8% 🔺+0.6% 264.43 KB 266.55 KB 45.52 KB 45.8 KB RN_OSS_PROD
ReactFabric-profiling.js +0.8% +0.6% 276.46 KB 278.62 KB 47.82 KB 48.09 KB RN_OSS_PROFILING

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-test-utils.production.min.js 0.0% 0.0% 13.05 KB 13.05 KB 4.8 KB 4.8 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 137.42 KB 137.42 KB 35.16 KB 35.16 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.16 KB 1.16 KB 657 B 659 B NODE_PROD
react-dom-server.browser.production.min.js 0.0% 0.0% 19.88 KB 19.88 KB 7.45 KB 7.45 KB UMD_PROD
ReactDOMForked-dev.js -0.0% 0.0% 1.04 MB 1.04 MB 238.96 KB 238.96 KB FB_WWW_DEV
react-dom.development.js +0.2% +0.2% 918.95 KB 921.17 KB 201.85 KB 202.23 KB UMD_DEV
react-dom.production.min.js 🔺+0.3% 🔺+0.3% 120.66 KB 121.04 KB 38.73 KB 38.84 KB UMD_PROD
react-dom.profiling.min.js +0.3% +0.3% 124.65 KB 125.01 KB 39.95 KB 40.08 KB UMD_PROFILING
ReactDOMTesting-dev.js -0.1% -0.0% 963.65 KB 963.12 KB 215.07 KB 214.98 KB FB_WWW_DEV
react-dom.development.js +0.2% +0.2% 874.73 KB 876.81 KB 199.3 KB 199.68 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 406.23 KB 406.23 KB 74.88 KB 74.89 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% 0.0% 131.64 KB 131.64 KB 34.97 KB 34.97 KB NODE_DEV
react-dom.production.min.js 🔺+0.3% 🔺+0.3% 120.79 KB 121.15 KB 37.79 KB 37.9 KB NODE_PROD
react-dom-test-utils.development.js 0.0% 0.0% 75.65 KB 75.65 KB 20.23 KB 20.23 KB UMD_DEV
react-dom.profiling.min.js +0.3% +0.2% 124.9 KB 125.25 KB 39.05 KB 39.13 KB NODE_PROFILING
react-dom-test-utils.production.min.js 0.0% 0.0% 13.17 KB 13.17 KB 4.89 KB 4.89 KB UMD_PROD
ReactDOM-dev.js -0.0% 0.0% 1.04 MB 1.04 MB 236.76 KB 236.77 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% 0.0% 70.46 KB 70.46 KB 19.73 KB 19.73 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 5.6 KB 5.6 KB 1.86 KB 1.86 KB NODE_DEV
react-dom-server.browser.development.js 0.0% 0.0% 130.37 KB 130.37 KB 34.72 KB 34.72 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.8 KB 19.8 KB 7.43 KB 7.43 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.2% 5.35 KB 5.35 KB 1.79 KB 1.8 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.19 KB 1.19 KB 696 B 697 B UMD_PROD
ReactDOMServer-dev.js 0.0% 0.0% 148.32 KB 148.32 KB 37.67 KB 37.67 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 47.44 KB 47.44 KB 11.11 KB 11.11 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1 KB 1 KB 608 B 609 B NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js -0.1% -0.0% 618.4 KB 617.94 KB 130.09 KB 130.08 KB FB_WWW_DEV
react-art.development.js +0.3% +0.3% 644.36 KB 646.59 KB 135.86 KB 136.24 KB UMD_DEV
react-art.production.min.js 🔺+0.3% 🔺+0.2% 107.79 KB 108.15 KB 32.71 KB 32.79 KB UMD_PROD
react-art.development.js +0.4% +0.3% 548.19 KB 550.27 KB 118.28 KB 118.67 KB NODE_DEV
react-art.production.min.js 🔺+0.5% 🔺+0.5% 72.79 KB 73.14 KB 21.83 KB 21.93 KB NODE_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactTestRenderer-dev.js -0.1% -0.0% 581.71 KB 581.26 KB 122.99 KB 122.94 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% 0.0% 39.16 KB 39.16 KB 9.57 KB 9.57 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 0.0% 12.73 KB 12.73 KB 3.96 KB 3.97 KB UMD_PROD
react-test-renderer.development.js +0.4% +0.3% 581.18 KB 583.4 KB 121.05 KB 121.42 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.5% 🔺+0.3% 74.95 KB 75.32 KB 22.82 KB 22.9 KB UMD_PROD
react-test-renderer.development.js +0.4% +0.3% 554.12 KB 556.2 KB 119.58 KB 119.97 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.5% 🔺+0.3% 74.76 KB 75.12 KB 22.5 KB 22.57 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.3% +0.3% 603.29 KB 605.35 KB 127.9 KB 128.27 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.4% 🔺+0.3% 82.2 KB 82.56 KB 24.59 KB 24.65 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (stable)

Generated by 🚫 dangerJS against a6ec644

@sizebot
Copy link

sizebot commented May 27, 2020

Details of bundled changes.

Comparing: b41beb1...a6ec644

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-prod.js 🔺+0.8% 🔺+0.6% 264.45 KB 266.56 KB 45.53 KB 45.81 KB RN_OSS_PROD
ReactFabric-profiling.js +0.8% +0.6% 276.47 KB 278.63 KB 47.83 KB 48.1 KB RN_OSS_PROFILING
ReactNativeRenderer-prod.js 🔺+0.4% 🔺+0.3% 272.48 KB 273.45 KB 47.06 KB 47.21 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js +0.3% +0.3% 284.53 KB 285.47 KB 49.35 KB 49.52 KB RN_OSS_PROFILING
ReactNativeRenderer-dev.js +0.3% +0.3% 670.4 KB 672.49 KB 143.85 KB 144.25 KB RN_FB_DEV
ReactNativeRenderer-prod.js 🔺+0.4% 🔺+0.3% 272.43 KB 273.41 KB 47.04 KB 47.19 KB RN_FB_PROD
ReactNativeRenderer-profiling.js +0.3% +0.3% 284.48 KB 285.42 KB 49.33 KB 49.5 KB RN_FB_PROFILING
ReactFabric-dev.js +0.3% +0.3% 647.09 KB 649.24 KB 138.7 KB 139.1 KB RN_OSS_DEV
ReactFabric-dev.js +0.3% +0.3% 651.58 KB 653.72 KB 139.42 KB 139.81 KB RN_FB_DEV
ReactFabric-prod.js 🔺+0.8% 🔺+0.6% 264.41 KB 266.53 KB 45.52 KB 45.8 KB RN_FB_PROD
ReactNativeRenderer-dev.js +0.3% +0.3% 665.92 KB 668.01 KB 143.16 KB 143.58 KB RN_OSS_DEV
ReactFabric-profiling.js +0.8% +0.6% 276.43 KB 278.59 KB 47.81 KB 48.08 KB RN_FB_PROFILING

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-test-utils.development.js 0.0% 0.0% 75.66 KB 75.66 KB 20.23 KB 20.24 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.2% 5.36 KB 5.36 KB 1.8 KB 1.8 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 13.18 KB 13.18 KB 4.9 KB 4.9 KB UMD_PROD
ReactDOMTesting-dev.js -0.1% -0.0% 937.86 KB 937.33 KB 209.53 KB 209.45 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.2 KB 1.2 KB 704 B 705 B UMD_PROD
react-dom.development.js +0.2% +0.2% 953.13 KB 955.35 KB 208.44 KB 208.8 KB UMD_DEV
react-dom.production.min.js 🔺+0.3% 🔺+0.3% 125.44 KB 125.82 KB 40.18 KB 40.3 KB UMD_PROD
ReactDOMForked-dev.js -0.0% -0.0% 1.02 MB 1.02 MB 233.31 KB 233.31 KB FB_WWW_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 20.34 KB 20.34 KB 7.52 KB 7.52 KB UMD_PROD
react-dom.profiling.min.js +0.3% +0.2% 129.55 KB 129.91 KB 41.4 KB 41.5 KB UMD_PROFILING
react-dom.development.js +0.2% +0.2% 907.44 KB 909.52 KB 205.82 KB 206.21 KB NODE_DEV
react-dom-server.browser.development.js 0.0% 0.0% 137.35 KB 137.35 KB 36.47 KB 36.47 KB NODE_DEV
react-dom.production.min.js 🔺+0.3% 🔺+0.2% 125.63 KB 125.99 KB 39.23 KB 39.31 KB NODE_PROD
react-dom-server.browser.production.min.js 0.0% 0.0% 20.26 KB 20.26 KB 7.51 KB 7.51 KB NODE_PROD
react-dom.profiling.min.js +0.3% +0.1% 129.88 KB 130.24 KB 40.54 KB 40.6 KB NODE_PROFILING
ReactDOM-dev.js -0.0% -0.0% 1.02 MB 1.02 MB 231.2 KB 231.19 KB FB_WWW_DEV
ReactDOMServer-dev.js 0.0% 0.0% 144.29 KB 144.29 KB 36.69 KB 36.69 KB FB_WWW_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 5.61 KB 5.61 KB 1.86 KB 1.87 KB NODE_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.17 KB 1.17 KB 665 B 667 B NODE_PROD
react-dom-test-utils.development.js 0.0% 0.0% 70.47 KB 70.47 KB 19.74 KB 19.74 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 4.87 KB 4.87 KB 1.7 KB 1.7 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 13.06 KB 13.06 KB 4.81 KB 4.81 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.02 KB 1.02 KB 616 B 617 B NODE_PROD
react-dom-server.node.development.js 0.0% 0.0% 138.62 KB 138.62 KB 36.72 KB 36.73 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 20.68 KB 20.68 KB 7.66 KB 7.66 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.3% +0.3% 669.06 KB 671.28 KB 141.03 KB 141.42 KB UMD_DEV
react-art.production.min.js 🔺+0.3% 🔺+0.2% 111.15 KB 111.51 KB 33.69 KB 33.76 KB UMD_PROD
react-art.development.js +0.4% +0.3% 571.85 KB 573.94 KB 123.3 KB 123.68 KB NODE_DEV
react-art.production.min.js 🔺+0.5% 🔺+0.3% 76.1 KB 76.45 KB 22.84 KB 22.9 KB NODE_PROD
ReactART-dev.js -0.1% -0.0% 608.38 KB 607.93 KB 128.11 KB 128.09 KB FB_WWW_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer-shallow.development.js 0.0% 0.0% 39.17 KB 39.17 KB 9.58 KB 9.58 KB UMD_DEV
ReactTestRenderer-dev.js -0.1% -0.0% 581.73 KB 581.28 KB 122.99 KB 122.94 KB FB_WWW_DEV
react-test-renderer.development.js +0.4% +0.3% 581.2 KB 583.43 KB 121.06 KB 121.44 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.5% 🔺+0.3% 74.98 KB 75.35 KB 22.84 KB 22.92 KB UMD_PROD
react-test-renderer.development.js +0.4% +0.3% 554.15 KB 556.23 KB 119.59 KB 119.98 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.5% 🔺+0.3% 74.78 KB 75.14 KB 22.52 KB 22.59 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.3% +0.3% 629.34 KB 631.41 KB 133.38 KB 133.75 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.4% 🔺+0.3% 85.93 KB 86.29 KB 25.66 KB 25.73 KB NODE_PROD
react-reconciler-reflection.development.js 0.0% 0.0% 17.72 KB 17.72 KB 5.24 KB 5.24 KB NODE_DEV
react-reconciler-reflection.production.min.js 0.0% 🔺+0.1% 2.93 KB 2.93 KB 1.21 KB 1.21 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against a6ec644

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a6ec644:

Sandbox Source
elastic-archimedes-r2c89 Configuration

@bvaughn
Copy link
Contributor Author

bvaughn commented May 27, 2020

Seems like we need to decide whether this is going to go out in v17 or v18 before I land it. @sebmarkbage seemed unsure about v17.

@sebmarkbage
Copy link
Collaborator

Meh. Let's just not use it as precedence to add more.

@bvaughn bvaughn merged commit 86b4070 into facebook:master May 28, 2020
@bvaughn bvaughn deleted the passive-effects-cleanup branch May 28, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@acdlite acdlite acdlite approved these changes

@gaearon gaearon Awaiting requested review from gaearon

@trueadm trueadm Awaiting requested review from trueadm

@lunaruan lunaruan Awaiting requested review from lunaruan

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passive effect destroy and create functions are interleaved
5 participants
@bvaughn @sizebot @sebmarkbage @acdlite @facebook-github-bot