Profiler: Don't count timed out (hidden) subtrees in base duration #18966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
commented
May 20, 2020
| @@ -1725,6 +1725,18 @@ function resetChildLanes(completedWork: Fiber) { | |||
| treeBaseDuration += child.treeBaseDuration; | |||
| child = child.sibling; | |||
| } | |||
|
|
|||
| const isTimedOutSuspense = | |||
There was a problem hiding this comment.
Implementation note: I chose to subtract the base duration value after the child loop, rather than doing the check inline, because a single check with a possible subtraction seemed better than a frequent check inside of the child loop. Happy to refactor if there's concern about the approach.
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e7b3c1e:
|
Details of bundled changes.Comparing: a30a1c6...e7b3c1e react-native-renderer
react-dom
react-art
react-test-renderer
react-reconciler
Size changes (stable) |
Details of bundled changes.Comparing: a30a1c6...e7b3c1e react-dom
react-art
react-test-renderer
react-reconciler
react-native-renderer
Size changes (experimental) |
gaearon
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Profiler previously over-reported the base duration value by including times pent in hidden subtrees.