chore: upgrade to Jest 26 #18816
Closed
chore: upgrade to Jest 26 #18816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f40c39a:
|
Details of bundled changes.Comparing: 9751935...f40c39a eslint-plugin-react-hooks
react-test-renderer
react-dom
Size changes (stable) |
Details of bundled changes.Comparing: 9751935...f40c39a react-test-renderer
react-dom
eslint-plugin-react-hooks
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (experimental) |
|
@SimenB We're running into a need for the latest jsdom, which would require us to get on Jest 26. Any chance you want to revive this PR? I'd be happy to assist with missing bits. |
|
Could we patch Jest 25 with a new jsdom patch version or does it include more changes then just this? |
|
We're gonna go with a custom jsdom fork for the time being but this is a liability. |
|
Can you override the default environment |
|
Currently on vacation, so I cannot promise being able to revive this within the next few weeks. Can do in early August though. But again, you can use |
|
PR to use jest-environment-jsdom-sixteen here, we can land that after JSDOM publishes the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As mentioned in #18815, it's incoming. I mostly wanna test the new (opt-in) fake timers, but I thought to open a PR with just the bump as well. Includes #18815, so you can choose to just merge this one if you want.
Draft for now as 26 is still alpha.
Test Plan
Green CI