Remove ReactDOM.useEvent and associated types+tests #18689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
trueadm
force-pushed
the
remove-use-event
branch
from
e0a2a41 to
f2116ae
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e0a2a41:
|
Details of bundled changes.Comparing: 0960b7b...eb8070d react-test-renderer
react-dom
react-art
react-native-renderer
react-reconciler
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eb8070d:
|
Details of bundled changes.Comparing: 0960b7b...eb8070d react-dom
react-native-renderer
react-art
react-test-renderer
react-reconciler
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
trueadm
force-pushed
the
remove-use-event
branch
from
f2116ae to
d3069d8
Compare
Remove tests Fix up look sharp Fix
trueadm
force-pushed
the
remove-use-event
branch
from
d3069d8 to
eb8070d
Compare
gaearon
reviewed
Apr 21, 2020
gaearon
reviewed
Apr 21, 2020
gaearon
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
ReactDOM.unstable_useEventAPI from the codebase. We are close to finding a lower level primitive to creating events in React without needing to couple the API to hooks only and that exploration might bring back some of the logic we had here, but ideally we'd probably revisit things again without bringing in as much of the overhead we had here. We'll likely bring back theuseFocusWithinanduseFocusAPIs once we have the alternative API available too.