Skip to content

Upgrade fbjs-scripts #18684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Upgrade fbjs-scripts #18684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cceb1fb
Upgrade fbjs-scripts
sebmarkbage Apr 21, 2020
3f4bea8
Upgrade Fresh test to Babel 7 transform
sebmarkbage Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"eslint-plugin-no-for-of-loops": "^1.0.0",
"eslint-plugin-react": "^6.7.1",
"eslint-plugin-react-internal": "link:./scripts/eslint-rules",
"fbjs-scripts": "0.8.3",
"fbjs-scripts": "1.2.0",
"filesize": "^6.0.1",
"flow-bin": "0.97",
"glob": "^7.1.6",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-refresh/src/__tests__/ReactFreshBabelPlugin-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ describe('ReactFreshBabelPlugin', () => {
}
`,
{
plugins: ['transform-es2015-modules-commonjs'],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaearon This is the Babel 6 version which was only accidentally available in our repo. This now uses the Babel 7 transform. Not sure what this is testing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this just makes sure the transform doesn't break it in some way. Makes sense to use the recent one.

plugins: ['@babel/transform-modules-commonjs'],
},
),
).toMatchSnapshot();
Expand Down
5 changes: 2 additions & 3 deletions packages/react-refresh/src/__tests__/__snapshots__/ReactFreshBabelPlugin-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,13 +289,12 @@ exports[`ReactFreshBabelPlugin includes custom hooks into the signatures when co
Object.defineProperty(exports, "__esModule", {
value: true
});

var _s = $RefreshSig$();

exports.default = App;

var _hooks = require("./hooks");

var _s = $RefreshSig$();

function App() {
_s();

Expand Down
Loading