Move beforeblur phase to prepareForCommit #18609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9301d38:
|
Details of bundled changes.Comparing: b928fc0...9301d38 react-dom
react-reconciler
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
Details of bundled changes.Comparing: b928fc0...9301d38 react-dom
react-reconciler
Size changes (experimental) |
trueadm
force-pushed
the
before-blur-move
branch
from
c51a3d3 to
3e4bb27
Compare
bvaughn
reviewed
Apr 14, 2020
bvaughn
approved these changes
Apr 14, 2020
| fiber.memoizedState = null; | ||
| fiber.pendingProps = null; | ||
| fiber.return = null; | ||
| fiber.sibling = null; |
There was a problem hiding this comment.
This seems like a nice change 👍
sebmarkbage
reviewed
Apr 14, 2020
gaearon
reviewed
Apr 14, 2020
sebmarkbage
reviewed
Apr 14, 2020
| @@ -95,6 +94,10 @@ import { | |||
| import {getListenerMapForElement} from '../events/DOMEventListenerMap'; | |||
| import {TOP_BEFORE_BLUR, TOP_AFTER_BLUR} from '../events/DOMTopLevelEventTypes'; | |||
|
|
|||
| // TODO: This is an exposed internal, we should move this around | |||
| // so this isn't the case. | |||
| import {isFiberInsideHiddenOrRemovedTree} from 'react-reconciler/src/ReactFiberTreeReflection'; | |||
There was a problem hiding this comment.
cc @acdlite in case this affects your fork. I don't think it will.
sebmarkbage
reviewed
Apr 14, 2020
sebmarkbage
approved these changes
Apr 14, 2020
Add comment Add comment
trueadm
force-pushed
the
before-blur-move
branch
from
f2d1396 to
9301d38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #18564. Specifically, this moves the
beforeblurlogic inReactDOMHostConfig, so that it occurs duringprepareForCommit– avoiding the issues with conflicting with a partially mutated tree. To do this logic we pass through a helper function toprepareForCommitcalledisInstanceInsideHiddenOrRemovedTree. This helps us determine if the "active element" is within a sub-tree that is either hidden or removed.Furthermore, the effeciency of this approach should be a nice improvement, as it means we have to do far less logic than before – along with a slight code size improvement.
I also applied the
detachFiberchanges from #18564 and included the regression test from that PR too.