Fix a mistake in ReactChildren refactor #18380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the bug.
These aren't directly observable. The arg wasn't used, it's accidental and I forgot to remove. The retval was triggering a codepath that was unnecessary (pushing to array) so I removed that too.
facebook-github-bot
added
CLA Signed
React Core Team
gaearon
commented
Mar 24, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f66dc55:
|
gaearon
commented
Mar 24, 2020
| escapedChildKey = escapeUserProvidedKey(childKey) + '/'; | ||
| } | ||
| mapIntoArray(mappedChild, array, escapedChildKey, c => c); | ||
| mapIntoArray(mappedChild, array, escapedChildKey, '', c => c); |
Collaborator
Author
There was a problem hiding this comment.
This is the fix. Oops.
trueadm
reviewed
Mar 24, 2020
sebmarkbage
approved these changes
Mar 24, 2020
Collaborator
|
lol at that branch name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of course I broke something in #18332. Luckily internal tests caught it.
I changed signature of one of the internal functions, but forgot to adjust the callsite. So there was a missing argument. The fix for that is 20fc0bd.
To prevent this from happening again and to turn my mistake into a learning experience, I added:
mapreturning an array — we didn't have that. 344e56c